Closed Bug 1388884 Opened 7 years ago Closed 7 years ago

Store bookmark "tombstones" for longer (forever?)

Categories

(Firefox for Android Graveyard :: Android Sync, enhancement, P1)

Product:
Firefox for Android Graveyard
Component:
Android Sync
Type:
enhancement

Tracking

(firefox57 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: Grisha, Assigned: Grisha)

References

Details

Attachments

(1 file)

Bug 1388884 - Do not delete bookmark tombstones
(deleted), text/x-review-board-request
rnewman
: review+
Details
Currently we clean up "tombstone" records, in groups of 5, after 20 days. In case of infrequent syncs this means missed deletions, resurrection of zombie bookmarks, and other bad things. We probably just want to store them forever.
Mainly affects sync, so moving the components. Going to do this and see if it'll help with Bug 1392716.
Assignee: nobody → gkruglov
Status: NEW → ASSIGNED
Component: Data Providers → Android Sync
Product: Firefox for Android → Android Background Services
Blocks: 1392716
Comment on attachment 8900081 [details] Bug 1388884 - Do not delete bookmark tombstones https://reviewboard.mozilla.org/r/171426/#review178714 Harmless, so long as you're sure we never create tombstones from remote deletions or for special folders.
Attachment #8900081 - Flags: review?(rnewman) → review+
Priority: -- → P1
Pushed by gkruglov@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ba4778825623 Do not delete bookmark tombstones r=rnewman
https://hg.mozilla.org/mozilla-central/rev/ba4778825623
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: