Closed
Bug 1389078
Opened 7 years ago
Closed 7 years ago
Sandbox Broker relies on <sys/cdefs.h> breaking non-glibc
Categories
(Core :: Security: Process Sandboxing, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: gcp, Assigned: gcp)
References
Details
(Whiteboard: sb+)
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
jld
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
No description provided.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gpascutto
Priority: -- → P1
Updated•7 years ago
|
Whiteboard: sb+
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8895857 [details]
Bug 1389078 - Remove (unneeded) usage of internal libc header.
https://reviewboard.mozilla.org/r/167148/#review172504
Attachment #8895857 -
Flags: review?(jld) → review+
Pushed by gpascutto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a08211592563
Remove (unneeded) usage of internal libc header. r=jld
Comment 4•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 5•7 years ago
|
||
Comment on attachment 8895857 [details]
Bug 1389078 - Remove (unneeded) usage of internal libc header.
Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:
Attachment #8895857 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 6•7 years ago
|
||
[Feature/Bug causing the regression]: Bug 1308400
[User impact if declined]: Increased burden on maintainers of downstream distros
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Landed a few days ago
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No, zero risk.
[Why is the change risky/not risky?]: Build-time change only. It either works or there's no build.
[String changes made/needed]: N/A
Updated•7 years ago
|
status-firefox56:
--- → affected
Comment 7•7 years ago
|
||
Comment on attachment 8895857 [details]
Bug 1389078 - Remove (unneeded) usage of internal libc header.
A build time change and should be low risk. Beta56+.
Attachment #8895857 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•7 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•