Closed Bug 13891 Opened 25 years ago Closed 25 years ago

Subject field doesn't reflect Reply/Forward and is blank

Categories

(SeaMonkey :: MailNews: Message Display, defect, P1)

x86
Windows NT
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: marina, Assigned: bugzilla)

References

Details

Steps to reproduce: -select a message in the Inbox; -click Reply(or Forward); //note: there is no Re: and the subject is blank (same happens with Forward) (when you get the message it doesn't carry Re: or For indication)
happens only on the POP server (IMAP is OK)
Assignee: phil → ducarroz
-> ducarroz
Note that this was working on yesterday's build. So we need to find out who checked in a code which affects this area. I added akkana and tague to the CC line since they along with nhotta might have worked in this area yesterday.
*** Bug 13953 has been marked as a duplicate of this bug. ***
Severity: normal → blocker
Priority: P3 → P1
Target Milestone: M11
This really should be a blocker for M11 -- raised priority also.
The loss of the quoted subject header happens regardless of the charset of the strings quoted, ASCII, Latin 1, Japanese, UTF-8, etc. Occurs under both HTML & Plain Text mail send options.
Status: NEW → ASSIGNED
It doesn't happen with my local build (Tuesday's pull with all my check in). I used pop, both reply and forward got correct headers generated.
In fact, the subject and the quoted body is lost. Is due by nsMailboxService::FetchMessage which failed because aDisplayConsumer isn't a WebShell. nsMailboxService::FetchMessage is called during the quoting of the message. As it failed, JS is stop with an uncaught exception error and therefore, the script that load the subject is never reached.
Jean-Francois, i don't believe this is your problem. FetchMessage is designed to work with or without a webshell. We just run the url differently if you pass in a webshell. Your failure isn't coming from there. Besides, if the fetch message really did fail, you wouldn't have gotten a message body. Lets add jefft to the cc list because he's the one that re-implemented reply and forward tuesday to no longer use the temp file hack. So things are different now.
Ok, I thing I found the real problem. in nsMailboxService::FetchMessage when the displayConsumer isn't a webshell, we then call RunMailboxUrl() instead of webshell->LoadURI() but we never reset rv which still carry the previous error. I will set rv to the result of RunMailboxUrl() and it should work again...
Hey Jean, Francois, I just got your message. Your right, we need to reset rv. if (NS_SUCCEEDED(rv) && webshell) rv = webshell->LoadURI(url, "view", nsnull, PR_TRUE); else RunMailboxUrl(url, aDisplayConsumer); Just set rv = RunMailboxUrl and that should fix your problem. I can check this in if you want too. Good catch.
Yes, it works well again. I will check it in when the tree open.
Summary: Subject field doesn't reflect Reply/Forward → Subject field doesn't reflect Reply/Forward and is blank
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Fixed and Checked in.
I updated the change of duccaroz checked in. The subject problem (this bug) has fixed. But the quoted body still doesn't show up. This happens in both pop and imap with or without the ducarroz change. Scott, Jean-Francois, did you see body was also working? If so, could be my local problem.
Noaki, the bug you described is filed as bug 14045.
Just FYI. The body disappearance (for both POP & IMAP) problem is new to today's build. It was quoted OK in yesterday's build. In yesterday's build, only the subject header disappears in POP3 only. When this bug was filed, only the subject header had this problem.
Status: RESOLVED → VERIFIED
verified with today's 1999-09-17 Win build.For both POP and IMAP the problem is gone.
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.