Closed Bug 1389211 Opened 7 years ago Closed 7 years ago

Update pdf.js to version 1.8.618

Categories

(Firefox :: PDF Viewer, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1387412 +++ Changes since last update: #8746 More robust getPage() error handling. #8752 ES6-ify the code in `web/dom_events.js` #8756 Remove leftover `args[0].code` checks from the `OPS.paintXObject` cases in evaluator.js #8761 Fallback to plain object for globalScope. #8762 Replace the `coded` property with `isType3Font` when building the font `properties` object in `PartialEvaluator.translateFont` #8764 Convert `DownloadManager` to an ES6 class
Confirmed on Try that this fixes bug 1368927 on Beta too. Will request uplift eventually.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Attached patch uplift request (deleted) — Splinter Review
Approval Request Comment [Feature/Bug causing the regression]: I'd like to get this on Beta to silence a very frequent orange (bug 1368927) [User impact if declined]: sad, sad, Ryan [Is this code covered by automated tests?]: yes [Has the fix been verified in Nightly?]: yes and I ran it through Try to confirm that the oranges go away [Needs manual test from QE? If yes, steps to reproduce]: none [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: low [Why is the change risky/not risky?]: makes some error handling more robust [String changes made/needed]: none
Attachment #8896438 - Flags: approval-mozilla-beta?
Comment on attachment 8896438 [details] [diff] [review] uplift request Update pdf.js and make Ryan happy. Beta56+. Should be in 56.0b3.
Attachment #8896438 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Blocks: 1391484
No longer blocks: 1391484
Type: defect → task
No longer depends on: 1387412
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: