Closed
Bug 1389255
Opened 7 years ago
Closed 7 years ago
Fix the styling of multitable section in about:telemetry
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: flyingrub, Assigned: flyingrub)
References
Details
Attachments
(1 file)
The headings in multi-table sections are oddly-sized (e.g. environment -> addons). The "activeAddons" heading is smaller than the following table heading / addon name. It is hard to separate from the rest of the sections as there is not enough space to the preceding element.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8895999 -
Flags: review?(gfritzsche) → review?(chutten)
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8895999 [details]
Bug 1389255 - Fix the styling of multitable section in about:telemetry
https://reviewboard.mozilla.org/r/167272/#review173610
::: toolkit/content/aboutTelemetry.css:300
(Diff revision 2)
> caption {
> font-weight: bold;
> white-space: nowrap;
> text-align: left;
> - font-size: large;
> + font-size: 24px;
> + margin: 24px 0 12px 0;
Can we get any of these values out of Common.css? Or peg them to the current font size?
Attachment #8895999 -
Flags: review?(chutten)
Comment on attachment 8895999 [details]
Bug 1389255 - Fix the styling of multitable section in about:telemetry
https://reviewboard.mozilla.org/r/167272/#review173996
::: toolkit/content/aboutTelemetry.css:300
(Diff revision 2)
> caption {
> font-weight: bold;
> white-space: nowrap;
> text-align: left;
> - font-size: large;
> + font-size: 24px;
> + margin: 24px 0 12px 0;
I don't think we can get them from common.css.
I cleaned it up a little and use em instead of px now.
Comment hidden (mozreview-request) |
Comment on attachment 8895999 [details]
Bug 1389255 - Fix the styling of multitable section in about:telemetry
https://reviewboard.mozilla.org/r/167272/#review173610
> Can we get any of these values out of Common.css? Or peg them to the current font size?
I switched to em instead of px. Also useless css removed.
Updated•7 years ago
|
Attachment #8895999 -
Flags: review?(gfritzsche) → review?(chutten)
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8895999 [details]
Bug 1389255 - Fix the styling of multitable section in about:telemetry
https://reviewboard.mozilla.org/r/167272/#review174036
Attachment #8895999 -
Flags: review?(chutten) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cca3c23a2235
Fix the styling of multitable section in about:telemetry r=chutten
Keywords: checkin-needed
Comment 9•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•