Closed
Bug 1389781
Opened 7 years ago
Closed 7 years ago
Remove border-bottom from the header in common.css
Categories
(Toolkit :: Themes, enhancement)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: flyingrub, Assigned: flyingrub)
References
Details
Attachments
(3 files)
In the previous design there was a border-bottom below the .header class in common.css. But I feel like this doesn't fit well with the new photon redesign.
Affected : about:telemetry, about:networking, about:addons.
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Assignee: nobody → flyinggrub
Status: NEW → ASSIGNED
Updated•7 years ago
|
Attachment #8896614 -
Flags: review?(dao+bmo)
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8896614 [details]
Bug 1389781 - Remove border-bottom from the header in common.css
https://reviewboard.mozilla.org/r/167894/#review173946
::: toolkit/themes/shared/in-content/common.inc.css
(Diff revision 1)
> }
>
> /* header */
>
> *|*.header {
> - border-bottom: 1px solid var(--in-content-header-border-color);
The name --in-content-header-border-color doesn't make sense for the remaining places where this is used. Can you clean this up?
Attachment #8896614 -
Flags: review?(dao+bmo)
Comment hidden (mozreview-request) |
Attachment #8896614 -
Flags: review?(dao+bmo)
Can I replace those : http://searchfox.org/mozilla-central/search?q=--in-content-header-border-color&case=true&path=
by --in-content-box-border-color that is recently updated to match photon (bug 1390832) ?
Comment 6•7 years ago
|
||
(In reply to flyingrub from comment #5)
> Can I replace those :
> http://searchfox.org/mozilla-central/search?q=--in-content-header-border-
> color&case=true&path=
> by --in-content-box-border-color that is recently updated to match photon
> (bug 1390832) ?
Sounds good to me.
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8896614 [details]
Bug 1389781 - Remove border-bottom from the header in common.css
https://reviewboard.mozilla.org/r/167894/#review176286
Attachment #8896614 -
Flags: review?(dao+bmo) → review+
Keywords: checkin-needed
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cef2e2a7b966
Remove border-bottom from the header in common.css r=dao
Keywords: checkin-needed
Comment 10•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•