Closed
Bug 1389868
Opened 7 years ago
Closed 7 years ago
Create bootstrap Sandboxes without indexedDB constructor by default
Categories
(Toolkit :: Add-ons Manager, enhancement)
Toolkit
Add-ons Manager
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We currently spend several milliseconds at startup creating these bindings, despite the fact that they're never used.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
Is this going to break anything in test pilot?
Flags: needinfo?(wclouser)
Flags: needinfo?(jhirsch)
|
||
Comment 3•7 years ago
|
||
Thanks for the ping. This doesn't affect Test Pilot or any active experiments right now. :jkt was saying it will affect the new lightbeam add-on though (not a test pilot experiment)
Flags: needinfo?(wclouser)
Flags: needinfo?(jkt)
Flags: needinfo?(jhirsch)
|
Assignee | |
Comment 4•7 years ago
|
||
If any extensions need an indexedDB constructor from a bootstrap sandbox, they can import it explicitly using Cu.importGlobalProperties. I'd be surprised if they actually used it directly from a bootstrap sandbox rather than a JSM, though.
|
||
Comment 5•7 years ago
|
||
The new Lightbeam is a web extension, the old isn't I think we are fine here.
Thanks :clouserw
Flags: needinfo?(jkt)
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8896672 [details]
Bug 1389868: Create bootstrap Sandboxes without indexedDB constructor by default.
https://reviewboard.mozilla.org/r/167982/#review173606
Attachment #8896672 -
Flags: review?(aswan) → review+
|
||
Updated•7 years ago
|
Whiteboard: [qf] → [qf:p3]
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cde80c96f44
Create bootstrap Sandboxes without indexedDB constructor by default. r=aswan
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Updated•3 years ago
|
Performance Impact: --- → P3
Whiteboard: [qf:p3]
You need to log in
before you can comment on or make changes to this bug.
Description
•