Closed Bug 1390006 Opened 7 years ago Closed 7 years ago

browser_BrowserUITelemetry_defaults.js is going to permafail on DevEdition when Gecko 57 merges to Beta on 2017-09-20

Categories

(Firefox :: Toolbars and Customization, defect, P1)

Unspecified
All
defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
57.1 - Aug 15
Tracking Status
firefox57 - verified

People

(Reporter: RyanVM, Assigned: Gijs)

References

Details

(Whiteboard: [photon-structure])

Attachments

(1 file)

[Tracking Requested - why for this release]: Permafailing DevEdition test on the next merge day. Looks like this test is failing because DevEdition has an extra button on the toolbar that the test isn't expecting to be there. https://public-artifacts.taskcluster.net/Zym-tmX2Q_e03PFcEC_RVg/0/public/test_info//mozilla-test-fail-screenshot_aQrgTf.png https://treeherder.mozilla.org/logviewer.html#?job_id=122811906&repo=try TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_BrowserUITelemetry_defaults.js | ["developer-button"] deepEqual [] - JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser/browser_BrowserUITelemetry_defaults.js :: test :: line 25
Flags: needinfo?(dao+bmo)
I expect this is my fault.
Flags: needinfo?(dao+bmo) → needinfo?(gijskruitbosch+bugs)
This broke because in bug 1354117 I moved the developer button into the palette by default, and so now it counts as "added" (from the palette to the toolbar) rather than "moved" (from the panel to the toolbar).
Assignee: nobody → gijskruitbosch+bugs
Blocks: 1354117
No longer blocks: 1363485
Status: NEW → ASSIGNED
Iteration: --- → 57.1 - Aug 15
Flags: needinfo?(gijskruitbosch+bugs)
Flags: qe-verify-
Flags: in-testsuite+
Priority: -- → P1
Whiteboard: [photon-structure]
Comment on attachment 8896929 [details] Bug 1390006 - fix up expectations of BrowserUITelemetry tests to match what devedition is doing, https://reviewboard.mozilla.org/r/168208/#review173404 Shouldn't that assertion just test for a different array (which includes the developer-button) in devedition? But that's not what this bug is about, so r=me.
Attachment #8896929 - Flags: review?(jhofmann) → review+
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f7124b5734fa fix up expectations of BrowserUITelemetry tests to match what devedition is doing, r=johannh
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: