Closed
Bug 1390006
Opened 7 years ago
Closed 7 years ago
browser_BrowserUITelemetry_defaults.js is going to permafail on DevEdition when Gecko 57 merges to Beta on 2017-09-20
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Tracking
()
People
(Reporter: RyanVM, Assigned: Gijs)
References
Details
(Whiteboard: [photon-structure])
Attachments
(1 file)
[Tracking Requested - why for this release]: Permafailing DevEdition test on the next merge day.
Looks like this test is failing because DevEdition has an extra button on the toolbar that the test isn't expecting to be there.
https://public-artifacts.taskcluster.net/Zym-tmX2Q_e03PFcEC_RVg/0/public/test_info//mozilla-test-fail-screenshot_aQrgTf.png
https://treeherder.mozilla.org/logviewer.html#?job_id=122811906&repo=try
TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_BrowserUITelemetry_defaults.js | ["developer-button"] deepEqual [] - JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser/browser_BrowserUITelemetry_defaults.js :: test :: line 25
Flags: needinfo?(dao+bmo)
Assignee | ||
Comment 1•7 years ago
|
||
I expect this is my fault.
Flags: needinfo?(dao+bmo) → needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 2•7 years ago
|
||
This broke because in bug 1354117 I moved the developer button into the palette by default, and so now it counts as "added" (from the palette to the toolbar) rather than "moved" (from the panel to the toolbar).
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Flags: qe-verify-
Flags: in-testsuite+
Priority: -- → P1
Whiteboard: [photon-structure]
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8896929 [details]
Bug 1390006 - fix up expectations of BrowserUITelemetry tests to match what devedition is doing,
https://reviewboard.mozilla.org/r/168208/#review173404
Shouldn't that assertion just test for a different array (which includes the developer-button) in devedition? But that's not what this bug is about, so r=me.
Attachment #8896929 -
Flags: review?(jhofmann) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f7124b5734fa
fix up expectations of BrowserUITelemetry tests to match what devedition is doing, r=johannh
Comment 7•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Reporter | ||
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
This is fixed, no need to track it.
You need to log in
before you can comment on or make changes to this bug.
Description
•