Closed
Bug 1390042
Opened 7 years ago
Closed 7 years ago
[Onboarding] The complete sign is not shown at first time when set the performance tour as the first item
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
VERIFIED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | verified |
People
(Reporter: gasolin, Assigned: gasolin)
References
Details
(Whiteboard: [photon-onboarding])
Attachments
(1 file)
Steps:
* put performance / sync / default browser as first tour by setting browser.onboarding.newtour to `performance,addons,customize,search,default,sync`
* open onboarding overlay via click fox icon
* The complete sign does not shown when any of above 3 tours is the first item
expect:
Show complete sign when first time show that tour.
The reason here is we only set those tours as auto-complete when we are handleing click event. We could handle it in gotoPage instead.
|
Assignee | |
Updated•7 years ago
|
Whiteboard: [photon-onboarding][triage]
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8896873 [details]
Bug 1390042 - [Onboarding] The complete sign is not shown at first time when set the performance tour as the first item;
https://reviewboard.mozilla.org/r/168164/#review173330
Attachment #8896873 -
Flags: review?(rexboy) → review+
|
|
Assignee | |
Updated•7 years ago
|
Flags: qe-verify+
Priority: -- → P1
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
|
||
Comment 5•7 years ago
|
||
This doesn't meet the review requirements in MozReview for Autoland to push it.
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/autoland.html#landing-commits
Keywords: checkin-needed
Pushed by flin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f348b0c84139
[Onboarding] The complete sign is not shown at first time when set the performance tour as the first item;r=rexboy
|
||
Updated•7 years ago
|
QA Contact: jwilliams
Target Milestone: --- → Firefox 57
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
|
||
Comment 8•7 years ago
|
||
I have verified this issue is fixed with today's nightly.
Status: RESOLVED → VERIFIED
|
||
Comment 9•7 years ago
|
||
I can confirm this issue is not occurring on Fx 57.0b7, I verified on Windows 10 x64 and mac OS X 10.12.6.
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•