Closed Bug 1390138 Opened 7 years ago Closed 7 years ago

Crash in core::result::unwrap_failed<T> | webrender::renderer::LazilyCompiledShader::bind

Categories

(Core :: Graphics: WebRender, defect)

57 Branch
Unspecified
Windows 10
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- disabled
firefox57 --- fixed

People

(Reporter: marcia, Assigned: sotaro)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file, 5 obsolete files)

This bug was filed from the Socorro interface and is report bp-87d7e75e-2a2d-43e0-b914-b66820170813. ============================================================= Seen while looking at nightly crashes - crashes started using 20170812100345: http://bit.ly/2wJ0yQD Bug 1385003 is in that time frame.
We really need some way to get the panic messages into the crash report.
Version: Trunk → 57 Branch
Assignee: nobody → sotaro.ikeda.g
Depends on: 1394338
Attached patch wip (obsolete) (deleted) — Splinter Review
Attached patch wip (obsolete) (deleted) — Splinter Review
Attachment #8902169 - Attachment is obsolete: true
Attached patch wip patch (obsolete) (deleted) — Splinter Review
Attachment #8902496 - Attachment is obsolete: true
Attachment #8903031 - Attachment is obsolete: true
Attached patch patch - Add render() error handling to gecko (obsolete) (deleted) — Splinter Review
Attachment #8903053 - Attachment is obsolete: true
Attachment #8903055 - Attachment is obsolete: true
Attachment #8903395 - Flags: review?(bugmail)
Comment on attachment 8903395 [details] [diff] [review] patch - Add render() error handling to gecko Review of attachment 8903395 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/ipc/GPUProcessManager.cpp @@ +447,5 @@ > "Failed to make render context current", > NS_LITERAL_CSTRING("FEATURE_FAILURE_WEBRENDER_MAKE_CURRENT")); > + } else if (aError == wr::WebRenderError::RENDER) { > + gfx::gfxConfig::GetFeature(gfx::Feature::WEBRENDER).ForceDisable( > + gfx::FeatureStatus::Unavailable, This should probably be FeatureStatus::Failed or FeatureStatus::Broken, since we tried to enable but then it failed later. ::: gfx/webrender_bindings/src/bindings.rs @@ +449,5 @@ > + println!(" Failed to render: {:?}", e); > + let msg = CString::new(format!("wr_renderer_render: {:?}", e)).unwrap(); > + unsafe { > + gfx_critical_note(msg.as_ptr()); > + } nit: indentation
Attachment #8903395 - Flags: review?(bugmail) → review+
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5ca9c4d3658c Add render() error handling to gecko. r=jrmuizel
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Blocks: 1397770
Blocks: 1397831
Blocks: 1398241
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: