Closed
Bug 1390138
Opened 7 years ago
Closed 7 years ago
Crash in core::result::unwrap_failed<T> | webrender::renderer::LazilyCompiledShader::bind
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | disabled |
firefox57 | --- | fixed |
People
(Reporter: marcia, Assigned: sotaro)
References
(Blocks 1 open bug)
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file, 5 obsolete files)
(deleted),
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is
report bp-87d7e75e-2a2d-43e0-b914-b66820170813.
=============================================================
Seen while looking at nightly crashes - crashes started using 20170812100345: http://bit.ly/2wJ0yQD
Bug 1385003 is in that time frame.
Comment 1•7 years ago
|
||
We really need some way to get the panic messages into the crash report.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8902169 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
See Also: → https://github.com/servo/webrender/issues/1631
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8902496 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
See Also: → https://github.com/servo/webrender/pull/1633
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8903031 -
Attachment is obsolete: true
Assignee | ||
Comment 6•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8903053 -
Attachment is obsolete: true
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8903055 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8903395 -
Flags: review?(bugmail)
Comment 8•7 years ago
|
||
Comment on attachment 8903395 [details] [diff] [review]
patch - Add render() error handling to gecko
Review of attachment 8903395 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/ipc/GPUProcessManager.cpp
@@ +447,5 @@
> "Failed to make render context current",
> NS_LITERAL_CSTRING("FEATURE_FAILURE_WEBRENDER_MAKE_CURRENT"));
> + } else if (aError == wr::WebRenderError::RENDER) {
> + gfx::gfxConfig::GetFeature(gfx::Feature::WEBRENDER).ForceDisable(
> + gfx::FeatureStatus::Unavailable,
This should probably be FeatureStatus::Failed or FeatureStatus::Broken, since we tried to enable but then it failed later.
::: gfx/webrender_bindings/src/bindings.rs
@@ +449,5 @@
> + println!(" Failed to render: {:?}", e);
> + let msg = CString::new(format!("wr_renderer_render: {:?}", e)).unwrap();
> + unsafe {
> + gfx_critical_note(msg.as_ptr());
> + }
nit: indentation
Attachment #8903395 -
Flags: review?(bugmail) → review+
Updated•7 years ago
|
Blocks: stage-wr-nightly
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ca9c4d3658c
Add render() error handling to gecko. r=jrmuizel
Comment 10•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•7 years ago
|
status-firefox55:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•