The URL bar in About:newtab asks the user to "Search or Enter Address". To The Label's left is and (i) icon that has no function, and is not in support of the text. The (i) icon should be a search magnifying glass icon.

This is strictly out of scope for photon-visual this late in the game, but with some luck it's an easy fix. Let's give it a try.

Shouldn't this be faded out a little more? The screenshot shows it in the same opacity as the faded out (i) icon right now...

(In reply to Johann Hofmann [:johannh] from comment #3) > Shouldn't this be faded out a little more? I see no reason why we would want that. > The screenshot shows it in the > same opacity as the faded out (i) icon right now... Not over here on Linux but I haven't compared it elsewhere.

Comment on attachment 8897845 [details] Bug 1390359 - Replace faded out (i) icon with a search icon when the location bar is empty or modified. https://reviewboard.mozilla.org/r/169138/#review175102 Johann's right, Bryan's screenshot shows the icon with less opacity than this patch gives it. If there's confusion about that, please clear it up with Bryan. Also, this patch gives history results and the heuristic "Visit" result the magnifying glass icon too, and that doesn't seem right. The info icon isn't necessarily right for those either, but the "search" icon is certainly more wrong than that.

(In reply to Drew Willcoxon :adw from comment #5) > Comment on attachment 8897845 [details] > Bug 1390359 - Replace faded out (i) icon with a search icon when the > location bar is empty or modified. > > https://reviewboard.mozilla.org/r/169138/#review175102 > > Johann's right, Bryan's screenshot shows the icon with less opacity than > this patch gives it. If there's confusion about that, please clear it up > with Bryan. Bryan, please clarify if the search icon should be faded out. FWIW, I see no reason why it should be faded out. > Also, this patch gives history results and the heuristic "Visit" result the > magnifying glass icon too, and that doesn't seem right. The info icon isn't > necessarily right for those either, but the "search" icon is certainly more > wrong than that. The user is searching their history in this case. If the search icon only meant web search, then this bug wouldn't even make sense in the first place. The icon positioned at the start of the input field basically says "enter whatever you want and we'll try to give you something useful." It doesn't say that every selected result is a web search.

> Bryan, please clarify if the search icon should be faded out. FWIW, I see no > reason why it should be faded out. The icon is faded because it's informational only, and not clickable. The Icon is only meant to convey what the bar is good for. In this case finding stuff. > The user is searching their history in this case. If the search icon only > meant web search, then this bug wouldn't even make sense in the first place. While we have used this icon in the search the web search bar, we also have used the magnifying glass to show the users what folder a file came from. The magnifying glass generally means find, and finding history and bookmarks is covered under this interpretation. > The icon positioned at the start of the input field basically says "enter > whatever you want and we'll try to give you something useful." It doesn't > say that every selected result is a web search. yes, I agree with this statement.

Comment on attachment 8897845 [details] Bug 1390359 - Replace faded out (i) icon with a search icon when the location bar is empty or modified. https://reviewboard.mozilla.org/r/169138/#review177132 Thanks

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/df24976c2a46 Replace faded out (i) icon with a search icon when the location bar is empty or modified. r=adw

Backed out for MnH failures like https://treeherder.mozilla.org/logviewer.html#?job_id=125405968&repo=autoland

Backout by kwierso@gmail.com: https://hg.mozilla.org/integration/autoland/rev/737bd966895c Backed out changeset df24976c2a46 for test_chrome_element_css.py failures a=backout

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9528daed0767 Replace faded out (i) icon with a search icon when the location bar is empty or modified. r=adw

I have reproduced this bug with Nightly 57.0a1(2017-08-15) on Ubuntu 16.04, 64 bit! The fix is now verified on Latest Nightly 57.0a1 . Build ID 20170825100126 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0