Closed
Bug 1390503
Opened 7 years ago
Closed 7 years ago
Retry without the fast open on NS_ERROR_FAILURE
Categories
(Core :: Networking: HTTP, defect)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: dragana, Assigned: dragana)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
(deleted),
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
In waiting for bug 1386719 to be reviewd by a nspr peer, I made a work around for it in bug 1389079 that retries connection if ContinueConnect returns NS_ERROR_FAILURE.
I forgot to add this error to the list in SetFastOpenConnected :(
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8897417 -
Flags: review?(mcmanus)
Assignee | ||
Comment 2•7 years ago
|
||
Updated•7 years ago
|
Attachment #8897417 -
Flags: review?(mcmanus) → review+
Pushed by dd.mozilla@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/996189aa5b6f
Retry without fast open if error is NS_ERROR_FAILURE. r=mcmanus
Comment 4•7 years ago
|
||
I see a talos improvement from this landing:
== Change summary for alert #8797 (as of August 15 2017 17:38 UTC) ==
Improvements:
19% sessionrestore_many_windows windows10-64 pgo e10s 4,649.83 -> 3,783.67
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=8797
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•