Closed Bug 1390620 Opened 7 years ago Closed 7 years ago

Botched rebase: address (if needed) overrideScaleType and fitCenter for StreamPageIconLayout

Categories

(Firefox for Android Graveyard :: General, enhancement, P1)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
enhancement

Tracking

(firefox57 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

(Whiteboard: [mobileAS] 1.28)

Attachments

(1 file)

Bug 1390620: Set centerInside StreamPageIconLayout's FaviconView; add comments.
(deleted), text/x-review-board-request
sebastian
: review+
Details
In my rebase of bug 1301718, I needed to rebase over Sebastian's favicon changes that changed `overrideScaleType=false` and `scaleType=fitCenter` on the faviconView. However, I forgot to do the update during the rebase and now there's a TODO in the code. Verify it's actually a problem and fix it!
Note: all I landed was highlights changes so this should only affect the highlights icons.
Comment on attachment 8897559 [details] Bug 1390620: Set centerInside StreamPageIconLayout's FaviconView; add comments. https://reviewboard.mozilla.org/r/168832/#review175854
Attachment #8897559 - Flags: review?(s.kaspari) → review+
Pushed by michael.l.comella@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ecc3f03e5eae Set centerInside StreamPageIconLayout's FaviconView; add comments. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/ecc3f03e5eae
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: