I discovered on my local build, with a ton of desktop bookmarks imported via sync (for testing), I get 192 InvalidHighlightCandidateExceptions thrown from [1]. There are two problems here: 1) Exceptions should be truly exceptional and using them frequently will slow the application down (I wonder if that's why bug 1388187 is happening). 2) I logged the urls for these candidates and they are unexpectedly empty - perhaps we're pulling in non-url entities like bookmark folders? [1]: https://dxr.mozilla.org/mozilla-central/rev/b95b1638db48fc3d450b95b98da6bcd2f9326d2f/mobile/android/base/java/org/mozilla/gecko/activitystream/ranking/HighlightCandidate.java#163

fwiw, I could not get this to fire on Chenxia's phone [1] or my phone (though I don't have the same problem) so I wonder how often this happens in the wild... [1]: I thought it might because that device is sometimes missing highlights - bug 1390542

We don't know how often happen in wild but it'd be good to fix just in case - let's add a fix, even if hacky.

Comment on attachment 8900005 [details] Bug 1390685: Replace InvalidHighlightCandidateException with boolean return. https://reviewboard.mozilla.org/r/171328/#review176860

Pushed by michael.l.comella@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f4c83ccd2a29 Replace InvalidHighlightCandidateException with boolean return. r=sebastian