Closed
Bug 1390790
Opened 7 years ago
Closed 7 years ago
Label ScrollFrameHelper::ScheduleSyntheticMouseMove
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: bevis, Assigned: bevis)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
The timer callback of ScrollFrameHelper::ScheduleSyntheticMouseMove is shown up in the top unlabeled runnable list:
https://gist.github.com/bevis-tseng/12cf108f681467ca7d8f3088db4eb584
We want this to be labeled to gain more benefit from qDOM scheduling.
It seems that ScrollFrameHelper could access the corresponding nsIDocument via PresShell, so maybe we can set the event target of mScrollActivityTimer to mOuter->PresContext()->PresShell()->GetDocument()->EventTargetFor(TaskCategory::Other) to fix this.
Assignee | ||
Comment 1•7 years ago
|
||
Wait for the treeherder result to request the review:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9977490781eaaf593d15053ac3be05fdb61704b6
Assignee | ||
Comment 2•7 years ago
|
||
(update: SetTarget() once after timer constructed.)
Treeherder result looks fine:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e3fd9c91b9d1cc740d972561a66353923707360&selectedJob=123528296
Assignee: nobody → btseng
Attachment #8897788 -
Attachment is obsolete: true
Attachment #8897818 -
Flags: review?(tnikkel)
Updated•7 years ago
|
Attachment #8897818 -
Flags: review?(tnikkel) → review+
Pushed by btseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc147ac0de39
Label ScrollFrameHelper::ScheduleSyntheticMouseMove. r=tnikkel
Comment 4•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•