Closed
Bug 1390828
Opened 7 years ago
Closed 7 years ago
Form Autofill Preferences - Saved Addresses modal shows unnecessary scrollbars
Categories
(Toolkit :: Form Manager, defect, P3)
Tracking
()
VERIFIED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox56 | --- | unaffected |
firefox57 | --- | fixed |
People
(Reporter: alberts, Assigned: scottwu)
References
(Blocks 1 open bug)
Details
(Whiteboard: [form autofill])
Attachments
(3 files)
There is a horizontal and a vertical scrollbar outside of the area that should actually be scrollable. They clearly shouldn't be there and making it a bit hard to use the modal.
Comment 1•7 years ago
|
||
What build was this in?
Scott, I think you were adjusting some of the layouts to avoid clipping, do you have an existing bug on fixing this?
Flags: needinfo?(scwwu)
Priority: -- → P3
Whiteboard: [form autofill]
Comment 2•7 years ago
|
||
Looks like we had bug 1385813 for edit dialog only.
Reporter | ||
Comment 3•7 years ago
|
||
Just checked again with build ID 20170816100153, and it seems to be partly fixed. I now get only a horizontal scrollbar, which is invisible in macOS until you actually try scrolling to the left. New image attached.
(!) Actually, had a second look and resized the window to the smallest possible size (which only changed it by 1-2 pixel in height) and got both scrollbars back.
Assignee | ||
Comment 4•7 years ago
|
||
I think it's caused by changes in preferences stylesheets. The layout in edit address dialog is affected too (filed bug 1391148). Will look into this after I finish working on credit card preferences. Thanks for filing this bug.
Assignee: nobody → scwwu
Flags: needinfo?(scwwu)
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8901764 [details]
Bug 1390828 - Fix addresses and credit cards list margin and height issues.
https://reviewboard.mozilla.org/r/173200/#review178842
Attachment #8901764 -
Flags: review?(lchang) → review+
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f516952da0d4
Fix addresses and credit cards list margin and height issues. r=lchang
Keywords: checkin-needed
Comment 10•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
Comment 11•7 years ago
|
||
Comment on attachment 8901764 [details]
Bug 1390828 - Fix addresses and credit cards list margin and height issues.
Approval Request Comment
[Feature/Bug causing the regression]: autofill profile list dialog
[User impact if declined]: unnecessary scrollbars making UI look unpolished
[Is this code covered by automated tests?]: Yes, but not specifically for visual polish
[Has the fix been verified in Nightly?]: Yes, I don't see the problem in Nightly
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: small CSS changes only and it has baked for a while
[String changes made/needed]:
Attachment #8901764 -
Flags: approval-mozilla-beta?
Comment 12•7 years ago
|
||
Comment on attachment 8901764 [details]
Bug 1390828 - Fix addresses and credit cards list margin and height issues.
Nevermind, this should have been marked as unaffected since I think it due to preferences changes
Attachment #8901764 -
Flags: approval-mozilla-beta?
Updated•7 years ago
|
status-firefox56:
--- → unaffected
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•