Closed
Bug 1390835
Opened 7 years ago
Closed 7 years ago
Fix the sidebar in about:telemetry
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: flyingrub, Assigned: flyingrub)
References
Details
Attachments
(1 file)
The sidebar in about:telemetry can be scrolled horizontaly. We should not allow this.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8898305 [details]
Bug 1390835 - Fix the sidebar width in about:telemetry
https://reviewboard.mozilla.org/r/169674/#review174892
In what way does this stop the scrolling from happening?
Comment on attachment 8898305 [details]
Bug 1390835 - Fix the sidebar width in about:telemetry
https://reviewboard.mozilla.org/r/169674/#review174892
We now rely on a display: flex on the body. Before the .main-content with the width: 100% took all the space it could, interfering with the display: flex. (That's why I needed to add the min-width in the first place for .categories).
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8898305 [details]
Bug 1390835 - Fix the sidebar width in about:telemetry
https://reviewboard.mozilla.org/r/169674/#review175316
Attachment #8898305 -
Flags: review?(chutten) → review+
Keywords: checkin-needed
Comment 5•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s 0ba27bd2e3a2 -d 089706dfb481: rebasing 414587:0ba27bd2e3a2 "Bug 1390835 - Fix the sidebar width in about:telemetry r=chutten" (tip)
merging toolkit/content/aboutTelemetry.css
warning: conflicts while merging toolkit/content/aboutTelemetry.css! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request) |
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f48a6466aa91
Fix the sidebar width in about:telemetry r=chutten
Keywords: checkin-needed
Comment 8•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•