Closed Bug 1391012 Opened 7 years ago Closed 7 years ago

make it clear that fallbackMapping is unused when backgroundRate is 100

Categories

(Release Engineering Graveyard :: Applications: Balrog (frontend), enhancement, P1)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (frontend)
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: hemantsingh1612)

References

Details

(Whiteboard: [lang=python])

fallbackMapping doesn't do anything when backgroundRate is 100. Having it set can lead to confusion, especially for folks that haven't internalized what all of the Rule fields. It's probably best if we just disallow this. It may lead to slightly more churn, but it's probably worth it.
Blocks: 1392706
Mentor: bhearsum
Mentor: bhearsum
Priority: P3 → P1
Catlee pointed out that doing this will make it more difficult to make sure fallbackMapping is set correctly when backgroundRate changes to <100. He offered an alternative suggestion: make it clear in the UI that fallback mapping is unused if backgroundRate is 100. Greying it out or some other visual indicator would be ideal, and probably some title text that explains in more depth.
Component: Balrog: Backend → Balrog: Frontend
Summary: don't allow fallbackMapping to be set when backgroundRate is 100 → make it clear that fallbackMapping is unused when backgroundRate is 100
Assignee: nobody → hemantsingh1612
Commit pushed to master at https://github.com/mozilla/balrog https://github.com/mozilla/balrog/commit/3d158032f956c07927a16e66d5d46f65ba5f1280 Bug 1391012: make it clear that fallbackMapping is unused when backgroundRate is 100 (#413). r=bhearsum
Depends on: 1409738
This made it into production today. Thanks for your work here Hemant!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.