Closed
Bug 1391016
Opened 7 years ago
Closed 7 years ago
Only check "proxyAutoconfigUrl" if proxyType is set to "pac"
Categories
(Remote Protocol :: Marionette, enhancement, P1)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Blocks 1 open bug)
Details
(Whiteboard: [spec][17/08])
Attachments
(2 files)
Currently we always check the "proxyAutoconfigUrl" key even with the proxyType set to something else or completely missing.
It should only be checked/used when "pac" is set as proxyType.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Whiteboard: [spec][17/08]
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8897987 [details]
Bug 1391016 - Make sure that proxyType is required and a string.
https://reviewboard.mozilla.org/r/169288/#review174660
Attachment #8897987 -
Flags: review?(dburns) → review+
|
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8897988 [details]
Bug 1391016 - "proxyAutoconfigUrl" is required for proxyType "pac".
https://reviewboard.mozilla.org/r/169290/#review174666
Attachment #8897988 -
Flags: review?(dburns) → review+
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8897987 -
Flags: review?(ato)
Attachment #8897988 -
Flags: review?(ato)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 6•7 years ago
|
||
I had to push a minor update to fix an eslint failure in session.js.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2222b1931d36
Make sure that proxyType is required and a string. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/ebc619b0d656
"proxyAutoconfigUrl" is required for proxyType "pac". r=automatedtester
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2222b1931d36
https://hg.mozilla.org/mozilla-central/rev/ebc619b0d656
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•