Closed
Bug 1391257
Opened 7 years ago
Closed 7 years ago
Update MediaEngineWebrtc audio processing code to not use VoE interfaces
Categories
(Core :: WebRTC: Audio/Video, defect, P1)
Tracking
()
RESOLVED
DUPLICATE
of bug 1397793
Tracking | Status | |
---|---|---|
firefox57 | --- | affected |
People
(Reporter: dminor, Assigned: dminor)
References
Details
Some of the VoE interfaces are removed in webrtc.org branch 61 which requires changes to the audio processing APIs used in MediaEngineWebrtc. This work can be done against branch 57 of webrtc.org, which is likely easier than trying to make the changes as part of the branch 61 update.
Assignee | ||
Updated•7 years ago
|
Rank: 17
Comment 1•7 years ago
|
||
This is the first step of the plan, see 1391258 for the other part of the plan. Here, we're simply substituting the old interface that work by inheritance for an interface that works by composition.
We want to use the Audio Processing Module (APM) of webrtc.org [0].
The following needs to be done:
- [2] will replace our lock-free queue/AudioOutputObserver thing. We have the output data in [2] (graph thread)
- [3] is the location where we need to process the input data with the AEC and other processing algorithms, this is also on the graph thread. [4] is the method to use here. It's synchronous and we can call `InsertInGraph` or equivalent code after processing.
- [5] and [6] need to be adjusted to use the new `Config` objects.
- I have no idea on what to do with [7], it does not belong here.
[0]: http://searchfox.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/audio_processing/include/audio_processing.h#161
[1]: http://searchfox.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/audio_processing/include/audio_processing.h#418
[2]: http://searchfox.org/mozilla-central/source/dom/media/webrtc/MediaEngineWebRTCAudio.cpp#573
[3]: http://searchfox.org/mozilla-central/source/dom/media/webrtc/MediaEngineWebRTCAudio.cpp#690
[4]: http://searchfox.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/audio_processing/include/audio_processing.h#389
[5]: http://searchfox.org/mozilla-central/source/dom/media/webrtc/MediaEngineWebRTCAudio.cpp#736
[6]: http://searchfox.org/mozilla-central/source/dom/media/webrtc/MediaEngineWebRTCAudio.cpp#375
[7]: http://searchfox.org/mozilla-central/source/dom/media/webrtc/MediaEngineWebRTCAudio.cpp#830
Assignee | ||
Comment 2•7 years ago
|
||
Resolving this as a duplicate of jesup's bug.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•