Closed Bug 1391372 Opened 7 years ago Closed 7 years ago

Sync status activity slides out in a wrong direction

Categories

(Firefox for Android Graveyard :: Settings and Preferences, defect)

defect
Not set
normal

Tracking

(fennec+)

RESOLVED DUPLICATE of bug 1404162
Tracking Status
fennec + ---

People

(Reporter: Grisha, Unassigned)

References

Details

(Whiteboard: [FxA])

See video (samsung s6, Android 7.0): https://www.youtube.com/watch?v=qEUqgOWbRdE It behaves better in my Android O emulator, but distinctly differently from other items.
tracking-fennec: --- → ?
Hi Joe Please help decide the importance. This looks like something we should fix.
Flags: needinfo?(wehuang)
Flags: needinfo?(jcheng)
tracking-fennec: ? → +
actually what's wrong with it?
Flags: needinfo?(jcheng)
need animation polish?
added into tomorow's sprint planning doc
Flags: needinfo?(wehuang)
Whiteboard: [FNC][SPT57.3][BL]
The flow to launch Sync status activity is pretty different from other items: When clicking the Sync item, `FxAccountWebFlowActivity` is launched as a intermediary activity, soon it redirects to other activity by input arguments and finishes itself in onResume(). Also flag `FLAG_ACTIVITY_NO_ANIMATION` is enabled in the intent. When clicking other item, we just simply start an activity with a fragment in it(GeckoPreferences). To keep each items having same animation, maybe we can consider removing the redirection behavior to keep launching activity as simple as possible. Perhaps we can move the logic in `FxAccountWebFlowActivity` into a simple helper function and call it before actually launching an activity.
Blocks: 1398299
Whiteboard: [FNC][SPT57.3][BL]
Duping against the bug which aims to simplify this flow quite a bit.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Whiteboard: [FxA]
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.