Stylo reports the testcase as a CSS error while Gecko deals with it just fine.

-webkit-linear-gradient works fine. This makes me suspect that https://dxr.mozilla.org/servo/rev/fbabcaf614662a52eace21a64f27802c7eff4304/components/style/values/specified/image.rs#196 is not recognized for some reason.

Beta 56.0b3 x64 20170815141045 + Nightly 57 x64 20170817100132 @ Debian Testing: Grey-to-Black horizontal background gradient with Gecko vs. just a white background with Stylo.

Ok, it's more complicated than that. Stylo apparently does not like those arguments for the -moz-linear-gradient; a basic `-moz-linear-gradient(red, yellow)` works fine.

Hm, Nazim, didn't we implement -moz-linear-gradient in bug 1366544?

Working: -moz-linear-gradient(top,rgba(0,0,0,0.3) 0,#000 100%) Broken: -moz-linear-gradient(left,rgba(0,0,0,0.3) 0,#000 100%) Something about the parsing for LegacyPosition seems to be incorrect.

Oh, interestingly we have tons of tests about -moz- prefixed gradients but we don't have a test for this. There should be another return branch in the LegacyPosition parsing code. Sorry about that.

This looks better.

Oh, try run of this patch also showed a bug in gecko. Computed value of `-moz-linear-gradient(bottom, red, blue)` is wrong. See bug 1391534. Changing the test case because of that.

I don't know the details of position/gradient parsing well enough to feel comfortable reviewing this.

Comment on attachment 8898495 [details] Bug 1391432 - stylo: Add test cases for -moz-linear-gradient with single keyword https://reviewboard.mozilla.org/r/169850/#review175458 Heh, I had already taken a look at this patch yesterday... r=me, thanks for fixing! Should we also add a reftest for this? Or do you think parsing tests are enough? ::: servo/components/style/values/specified/position.rs:332 (Diff revision 3) > } > let x_pos = OriginComponent::Side(x_keyword); > if let Ok(y_lop) = input.try(|i| LengthOrPercentage::parse_quirky(context, i, allow_quirks)) { > return Ok(Self::new(x_pos, OriginComponent::Length(y_lop))) > } > + let _ = input.try(|i| i.expect_ident_matching("center")); Maybe use the same structure as the block below: ``` let y_pos = OriginComponent::Center; let _ = input.try(|i| i.expect_ident_matching("center")); ```

Pushed by canaltinova@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7314d7897f58 stylo: Add test cases for -moz-linear-gradient with single keyword r=emilio

Servo side: https://github.com/servo/servo/pull/18144

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #2) > Beta 56.0b3 x64 20170815141045 + Nightly 57 x64 20170817100132 @ Debian Testing: > Grey-to-Black horizontal background gradient with Gecko > vs. just a white background with Stylo. Verified fixed in Nightly 57 x64 20170820100343 @ Debian Testing.