Closed
Bug 1392153
Opened 7 years ago
Closed 7 years ago
Add margin between fxa name & email and manage account shouldn't open new window
Categories
(Firefox :: Settings UI, enhancement, P1)
Tracking
()
VERIFIED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | verified |
People
(Reporter: rickychien, Assigned: rickychien)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [photon-preference])
Attachments
(2 files)
See attachment. If the optional display name is shown, then we should have a margin between display name and email address to distinct them.
Assignee | ||
Comment 1•7 years ago
|
||
Another small issue will be fixed within this patch as well.
Clicking "Manage account" link as attachment displayed, we should just redirect current tab's url to new Firefox Account Management site instead of opening a new Firefox window.
Summary: Add a margin between about:preferences#sync's display name & email address → Add margin between fxa name & email and manage account shouldn't open new window
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
Current implementation has followed the visual spec to fix the uncovered display name in Fxa page. Helen will update the visual spec soon.
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8899447 [details]
Bug 1392153 - Display fxa name & email properly and manage account shouldn't open new window
https://reviewboard.mozilla.org/r/170726/#review175958
::: browser/themes/shared/incontentprefs/preferences.inc.css:572
(Diff revision 1)
> #fxaEmailAddress1,
> #fxaEmailAddress2,
> #fxaEmailAddress3 {
Can you please file a bug to change these from IDs to classes? We can use querySelector to find the correct email address element when needed.
Attachment #8899447 -
Flags: review?(jaws) → review+
Updated•7 years ago
|
Flags: qe-verify+
QA Contact: hani.yacoub
Whiteboard: [photon-preference][triage] → [photon-preference]
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> Comment on attachment 8899447 [details]
> Bug 1392153 - Display fxa name & email properly and manage account shouldn't
> open new window
>
> https://reviewboard.mozilla.org/r/170726/#review175958
>
> ::: browser/themes/shared/incontentprefs/preferences.inc.css:572
> (Diff revision 1)
> > #fxaEmailAddress1,
> > #fxaEmailAddress2,
> > #fxaEmailAddress3 {
>
> Can you please file a bug to change these from IDs to classes? We can use
> querySelector to find the correct email address element when needed.
I've updated those IDs to classes and use querySelector in latest update patch. thanks
Comment hidden (mozreview-request) |
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79a0409a6df7
Display fxa name & email properly and manage account shouldn't open new window r=jaws
Assignee | ||
Updated•7 years ago
|
Comment 9•7 years ago
|
||
bugherder |
Comment 10•7 years ago
|
||
Verified as fixed using the latest Nightly 57.0a1 (2017-08-25) on Ubuntu 16.04, Mac OS X 10.12 and Windows 10 x64.
Updated•7 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•