Closed Bug 1392201 Opened 7 years ago Closed 7 years ago

Label nsThreadShutdownAckEvent

Categories

(Core :: XPCOM, enhancement)

Product:
Core
Component:
XPCOM
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: bevis, Assigned: bevis)

References

Details

Attachments

(1 file, 1 obsolete file)

(v1) Patch: Label nsThreadShutdownAckEvent.
(deleted), patch
froydnj
: review+
Details | Diff | Splinter Review
This runnable shows up in the latest top unlabeled runnable list: https://gist.github.com/bevis-tseng/d8a918cb53112a82357c872ce15ee790 We could label this one with SystemGroup since it touches nothing related to a web content.
Attached patch (v1) Label nsThreadShutdownAckEvent. (obsolete) (deleted) — — Splinter Review
Choose SystemGroup to dispatch if nsThreadShutdownContext::mJoiningThread is actually the main thread. Wait for treeherder result to verify this fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5febbaaa04f76f29da74fa359bea8e54d027c08
The previous patch is incorrect. Upload the right one for reference.
Attachment #8899383 - Attachment is obsolete: true
Comment on attachment 8899391 [details] [diff] [review] (v1) Patch: Label nsThreadShutdownAckEvent. Label this runnable using SystemGroup if the main thread is joining this shutdown procedure.
Attachment #8899391 - Flags: review?(nfroyd)
Attachment #8899391 - Flags: review?(nfroyd) → review+
Pushed by btseng@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fe7d953913e0 Label nsThreadShutdownAckEvent. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/fe7d953913e0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee: nobody → bevistseng
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: