Closed Bug 1392230 Opened 7 years ago Closed 7 years ago

about:telemetry - Small design fixes

Categories

(Toolkit :: Telemetry, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: flyingrub, Assigned: flyingrub)

References

Details

Attachments

(5 files)

https://public.etherpad-mozilla.org/p/about_telemetry_feedback make a list of small css changes that doesn't need a bug for each ones.
Comment on attachment 8899433 [details] Bug 1392230 - Small design fixes in about:telemetry https://reviewboard.mozilla.org/r/170718/#review175868 Seems good. If you are going to put "checkin-needed" on the bug to have this merged, remember to use "leave-open" as well so the bug isn't automatically resolved on merge. This will allow you to work on further improvements within the same bug. Or just wait until all the improvements are up and r+ before marking "checkin-needed". Your choice.
Attachment #8899433 - Flags: review?(chutten) → review+
I prefer to wait and merge all the patch at once.
Comment on attachment 8899482 [details] Bug 1392230 - Fix placeholder text in about:telemetry https://reviewboard.mozilla.org/r/170760/#review176044 Seems about right
Attachment #8899482 - Flags: review?(chutten) → review+
Comment on attachment 8899777 [details] Bug 1392230 - Fix sql statements in about:telemetry https://reviewboard.mozilla.org/r/171112/#review176258 Simple and straightforward.
Attachment #8899777 - Flags: review?(chutten) → review+
Comment on attachment 8900689 [details] Bug 1392230 - Fix sidebar height in about:telemetry https://reviewboard.mozilla.org/r/172130/#review177466 ::: commit-message-a4708:1 (Diff revision 2) > +Bug 1392230 - Fix sidebar width in about:telemetry r?chutten This is fixing the height, no?
Attachment #8900740 - Flags: review?(chutten) → review+
Comment on attachment 8900689 [details] Bug 1392230 - Fix sidebar height in about:telemetry https://reviewboard.mozilla.org/r/172130/#review177630 r+ when you fix the commit message
Attachment #8900689 - Flags: review?(chutten) → review+
Keywords: checkin-needed
Still has unresolved issues in MozReview.
Keywords: checkin-needed
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/dd47c1e3d27e Small design fixes in about:telemetry r=chutten https://hg.mozilla.org/integration/autoland/rev/dce2841b8153 Fix sql statements in about:telemetry r=chutten https://hg.mozilla.org/integration/autoland/rev/2906056b9833 Fix placeholder text in about:telemetry r=chutten https://hg.mozilla.org/integration/autoland/rev/31785307b29f Fix sidebar height in about:telemetry r=chutten https://hg.mozilla.org/integration/autoland/rev/827da4c1d0ad Prevent table overflow in about:telemetry r=chutten
Keywords: checkin-needed
Depends on: 1399082
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: