Closed Bug 1392582 Opened 7 years ago Closed 7 years ago

Change the hover background url text color in awesomebar when using gnome3 dark theme

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1386934 +++ When using Firefox in Gnome 3 with dark theme the hover background url color is hardly visible on black background.
Attached image hover.png (deleted) —
See the black row in the middle which comes from mouse hover. It's difficult to notice it.
The code which affects it is here but I'm not sure how to fix that properly: diff --git a/browser/themes/linux/browser.css b/browser/themes/linux/browser.css --- a/browser/themes/linux/browser.css +++ b/browser/themes/linux/browser.css .autocomplete-richlistitem:hover, treechildren.searchbar-treebody::-moz-tree-row(hover) { background-color: hsla(0, 0%, 0%, 0.06); <<< wrong color when background is dark border-color: hsla(0, 0%, 0%, 0.1); }
Seems to be there since bug 1295458. Looks like this CSS exists on every platform, and should maybe use system colours on Linux, or something, or maybe opacity?
Blocks: 1295458
Whiteboard: [photon-visual][triage]
(In reply to Martin Stránský from comment #2) > The code which affects it is here but I'm not sure how to fix that properly: > > diff --git a/browser/themes/linux/browser.css > b/browser/themes/linux/browser.css > --- a/browser/themes/linux/browser.css > +++ b/browser/themes/linux/browser.css > > .autocomplete-richlistitem:hover, > treechildren.searchbar-treebody::-moz-tree-row(hover) { > background-color: hsla(0, 0%, 0%, 0.06); <<< wrong color when background > is dark > border-color: hsla(0, 0%, 0%, 0.1); > } We should use var(--arrowpanel-dimmed) as the background-color and var(--panel-separator-color) as the border-color.
Whiteboard: [photon-visual][triage]
Thanks, there's the patch attached. Works for me with light and dark themes.
Comment on attachment 8900221 [details] Bug 1392582 - Use arrowpanel-dimmed/panel-separator-color colors for awesome bar cursor, https://reviewboard.mozilla.org/r/171586/#review176730 Could you please update the windows/ and osx/ stylesheets for consistency? Thanks!
Attachment #8900221 - Flags: review?(dao+bmo)
Comment on attachment 8900221 [details] Bug 1392582 - Use arrowpanel-dimmed/panel-separator-color colors for awesome bar cursor, https://reviewboard.mozilla.org/r/171586/#review176832
Attachment #8900221 - Flags: review?(dao+bmo) → review+
Assignee: nobody → stransky
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/65efdf7b6bad Use arrowpanel-dimmed/panel-separator-color colors for awesome bar cursor,r=dao
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: