Closed
Bug 1392618
Opened 7 years ago
Closed 7 years ago
signed and unsigned integer causes warning (as error) in nsWindowsDllInterceptor.h
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor])
Attachments
(1 file)
No description provided.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
Comment on attachment 8899832 [details]
Bug 1392618 Fix comparison between signed and unsigned integer expressions
https://reviewboard.mozilla.org/r/171164/#review176270
I think we should just make mPatchedFnsLen be size_t, since that better matches the variable's purpose anyway.
You might then also have to fix up this line:
for (int i = 0; i < mPatchedFnsLen; i++) {
Attachment #8899832 -
Flags: review?(dmajor)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 5•7 years ago
|
||
Comment on attachment 8899832 [details]
Bug 1392618 Fix comparison between signed and unsigned integer expressions
https://reviewboard.mozilla.org/r/171164/#review176278
Thanks!
Attachment #8899832 -
Flags: review?(dmajor) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/653a497d1bae
Fix comparison between signed and unsigned integer expressions r=dmajor
Keywords: checkin-needed
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•