Soledad Penades [:sole] [:spenades] Assignee
	Description • 7 years ago

Before we declare DevTools "SDK free" we should run a series of "checks"

1) run egrep again to ensure there are no SDK mentions anywhere: egrep -Eoh "\"sdk/.*\"" -r devtools/ | sort | uniq -c
2) also do something similar to what has been done on bug 1350646 or Bug 1389469  when removing SDK modules from the Firefox tree: delete the actual SDK files and also delete mentions to them in the appropriate moz.build file. Then build Firefox and run tests, a try build... get things green or file follow up bugs as required.

At this point it is my understanding that other components such as Test Pilot are SDK free so it should be possible to remove the SDK completely and have working DevTools (once we're SDK free, of course)

	Soledad Penades [:sole] [:spenades] Assignee
	Comment 1 • 7 years ago

While

    egrep -Eoh "\"sdk/.*\"" -r devtools/ | sort | uniq -c

provides a *count* of appearances of "sdk/.*", the following:
 
    grep -ir "\"sdk/" devtools/*

provides a list of files and the specific string that matches, which is a tad more informative :-)

	Soledad Penades [:sole] [:spenades] Assignee
	Comment 2 • 7 years ago

This was a successful try where addon-sdk was removed and devtools tests pass https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e6396e26ce369a3d543cff720a428665ee0dd45

Kris, do you think this is covering all we need for devtools? Did I miss something?

	Soledad Penades [:sole] [:spenades] Assignee
	Comment 3 • 7 years ago

Well, Kris went further and he removed the addon-sdk folder in this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1371065

I pulled the code from m-c when it landed, made a try build and ran the DevTools test suite. We seem to be safe, so I'll mark this bug as resolved (fingers crossed...)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c536dd20ce83f459f6b32fbe107e8862e317ca33&selectedJob=130988473