Right now text layers are enabled by the "webrendest" flag, but we want them on by default when webrender is enabled. i.e. change the Override_WebRendest at [1] to Override_WebRender. I'm assuming :Gankro will pick this up when gets back from PTO, assuming nobody gets to it before he does. [1] http://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/gfx/thebes/gfxPrefs.h#543

Depends on: https://github.com/servo/webrender/issues/1624

Alright, the journey begins! ~230 reftest failures to triage https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2acfd1e790cee313a12bc9339f9960a6f768f74&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=133490358 (This try build already has ~400 text-writing-mode tests marked as failing)

glenn and lee's work has dropped us down to only about ~20 failures. Try push with annotations to get a clean build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d21e1d151e35dc06b6ec225e007d1df39ee8d5b Good: * New passes - yay! * Fuzz some blurred shadows (reasonable) * Fuzz some text-selection colors compared to svg (weird, but there was some existing similar fuzzing there, so I guess it's A Thing) Bad: * A bunch of failures from bad vertical snapping; probably similar to previous horizontal issue. * Some quirky decoration behaviours: needs investigation. * Missing diacritics: needs investigation. * Some messed up writing mode behaviour: needs investigation. So all in all, we have ~4 text bugs left on linux! (Ignoring the ~8 places we fallback to gecko, which represent hundreds of tests we'd otherwise fail) I think it'd be reasonable to flip the switch with these 4 sets of fails-if annotations as TODO.

Syntax error, better try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=88535944fe40fb1b3fab8f7faa5bd78db2232827&selectedJob=136124376 (still missed one or two, will finish up in the morning)

try push https://treeherder.mozilla.org/#/jobs?repo=try&revision=3571a49f92399da49e42071921622f4a175de183

Comment on attachment 8917364 [details] Bug 1392723 - Move text-layers from webrendest to webrender. https://reviewboard.mozilla.org/r/188376/#review193618 ::: commit-message-e897e:1 (Diff revision 1) > +Bug 1392723 - Move text from webrendest to webrender. r?kats s/text/text layers/

Comment on attachment 8917365 [details] Bug 1392723 - Mark tests as passing with webrender text-layers. https://reviewboard.mozilla.org/r/188378/#review193620 ::: commit-message-2e2af:1 (Diff revision 1) > +Bug 1392723 - Mark tests as passing with webrender text. r?kats s/text/text layers/

Comment on attachment 8917366 [details] Bug 1392723 - Give some fuzzy slack to blurred text shadow comparisons. https://reviewboard.mozilla.org/r/188380/#review193622

Comment on attachment 8917367 [details] Bug 1392723 - Add some more fuzzyness for selection colors. https://reviewboard.mozilla.org/r/188382/#review193624

Comment on attachment 8917368 [details] Bug 1392723 - Mark quirky decoration tests as failing. https://reviewboard.mozilla.org/r/188384/#review193626

Comment on attachment 8917369 [details] Bug 1392723 - Add failures for bad vertical text snapping. https://reviewboard.mozilla.org/r/188386/#review193628

Comment on attachment 8917370 [details] Bug 1392723 - Add failures for writing mode. https://reviewboard.mozilla.org/r/188388/#review193630 ::: commit-message-e7ddc:1 (Diff revision 1) > +Bug 1392723 - Add failures for writing mode. r?kats > + Update commit message to mention that the != tests pass but the == tests fail so the only annotation that makes sense (since the pattern-matching only applies to the test file) is random-if.

Comment on attachment 8917371 [details] Bug 1392723 - Add failures for diacritic stacking. https://reviewboard.mozilla.org/r/188390/#review193632

Comment on attachment 8917371 [details] Bug 1392723 - Add failures for diacritic stacking. https://reviewboard.mozilla.org/r/188390/#review193634 Oops, meant to r+

Comments addressed. Had to increase one fuzzyness value, due to typo.

All the outstanding issues have been migrated to Bug 1407627 as future work.

I retriggered the reftests, let's wait until those are all done.

Finally got a clean build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a662a2ff7de492e7e9d7f8cb13c874ab57affba

Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a337a84a9160 Move text-layers from webrendest to webrender. r=kats https://hg.mozilla.org/integration/autoland/rev/42d2a723d446 Mark tests as passing with webrender text-layers. r=kats https://hg.mozilla.org/integration/autoland/rev/e95a13b4a928 Give some fuzzy slack to blurred text shadow comparisons. r=kats https://hg.mozilla.org/integration/autoland/rev/93170ca68e3f Add some more fuzzyness for selection colors. r=kats https://hg.mozilla.org/integration/autoland/rev/55ab370c38b6 Mark quirky decoration tests as failing. r=kats https://hg.mozilla.org/integration/autoland/rev/e7a34e1180e2 Add failures for bad vertical text snapping. r=kats https://hg.mozilla.org/integration/autoland/rev/aa1903983ca7 Add failures for writing mode. r=kats https://hg.mozilla.org/integration/autoland/rev/4997d8582287 Add failures for diacritic stacking. r=kats

https://hg.mozilla.org/mozilla-central/rev/a337a84a9160 https://hg.mozilla.org/mozilla-central/rev/42d2a723d446 https://hg.mozilla.org/mozilla-central/rev/e95a13b4a928 https://hg.mozilla.org/mozilla-central/rev/93170ca68e3f https://hg.mozilla.org/mozilla-central/rev/55ab370c38b6 https://hg.mozilla.org/mozilla-central/rev/e7a34e1180e2 https://hg.mozilla.org/mozilla-central/rev/aa1903983ca7 https://hg.mozilla.org/mozilla-central/rev/4997d8582287