Closed Bug 1392768 Opened 7 years ago Closed 4 years ago

Rethink decision to automatically delete files when removing download history

Categories

(Firefox for Android Graveyard :: Download Manager, enhancement, P3)

Product:
Firefox for Android Graveyard
Component:
Download Manager
Platform:
All
Android
Type:
enhancement

Tracking

(fennec+)

Status:
RESOLVED INCOMPLETE
Tracking Flags:
Tracking Status
fennec + ---

People

(Reporter: JanH, Unassigned, NeedInfo)

References

Details

(Keywords: ux-consistency, ux-implementation-level)

Attachments

(4 files)

Bug 1392768 - Part 1 - Implement Gecko-side pref and prompt for clearing downloaded files.
(deleted), text/x-review-board-request
Details
Bug 1392768 - Part 2 - Expose the setting to delete downloaded files or not in our preferences.
(deleted), text/x-review-board-request
Details
Bug 1392768 - Part 3 - Extract a function for leaving our settings menu.
(deleted), text/x-review-board-request
Details
Bug 1392768 - Part 4 - If "Clear private data" triggers the new choice prompt, exit our settings in order to show the prompt.
(deleted), text/x-review-board-request
Details
We're regularly getting complaints about this and the decision from bug 1097619 is nearing almost its third anniversary (and the actual design decision is probably even older). As far as I've gathered, one reason for this decision was that Android devices weren't guaranteed to have a file manager, meaning that the entry in our download manager might potentially be the only way to access that file, so removing our download history could leave that file orphaned (and effectively leak the storage occupied by it). Starting from Android M, this is no longer true, as Android now ships with an inbuilt file manager that allows users to manage their storage without having to install additional apps. If we want to change this, I've got a patch almost ready that allows some choice here: On removing an entry from the download history, users are initially prompted whether the file should be deleted as well and can also choose their action (Keep/Delete) as the new default setting if they want. Note that on Android M and higher, this bug has a hard dependency on bug 1280184 - with the system download manager integration enabled, if we don't delete the file ourselves, the system download manager will do it for us.
It should be changed to "Download History", to be consistent with Firefox version on PC. Firefox shouldn't remove any files by itself now.
Severity: normal → major
status-firefox57: affected → ---
Keywords: ux-consistency, ux-implementation-level
(In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #1) > Firefox shouldn't remove any files by itself now. There's one difference - at the moment on Android we only have limited support for the "Open with..." download workflow. Our helper app dialogue only shows app that can handle the download *completely* by themselves, so for "opening" a file in an app that only supports accessing files directly from the local storage you still have to download the file normally. If you predominantly download that kind of "temporary" files just for viewing, then being able to clear them up directly from within Firefox can be useful.
I still lean towards deleting by default. File management in Android is rather weak. Though I do believe we should stop conflating download history and download files.
From the time when we had a public UI telemetry dashboard I seem to remember that not many people actually changed their settings, hence the idea to initially prompt, so people knew - something was up - they'd have a choice to delete or not - and could choose a default if they wished But then of course people don't like reading dialogue boxes, either, so who knows...
ni walkingice cause he's also working on similar thing Hi Joe. Wesly Please help prioritize this
tracking-fennec: ? → +
Flags: needinfo?(wehuang)
Flags: needinfo?(walkingice0204)
Flags: needinfo?(jcheng)
Priority: -- → P3
I'll try putting my patch up over the weekend for further feedback and discussion.
Note: To test this for yourself on Android 6+, the current patch for bug 1280184 (https://reviewboard-hg.mozilla.org/gecko/rev/7c975d34dad291b308532b30ed1ed8068f27cdcb) must be included as well, otherwise the file will be deleted anyway by the system download manager.
I feel we need XU's comment to confirm the design before moving forward, and P3 is fair until it happens. ni Jack.
Flags: needinfo?(wehuang) → needinfo?(jalin)
For me, I would suggest proposal 1: we can have 2 options "Remove from list" and "Delete file" proposal 2: show popup to ask users if they want to delete downloaded file at the same time after pressing delete. I have studied some browsers, many browsers' delete behavior is same as what I suggested. But Chrome's behavior is the same as Firefox.
Flags: needinfo?(jalin)
Just a comment, maybe to help with the decision. Firefox Focus keeps downloaded files
Firefox privacy related settings apply to Firefox _own_ data, which means that downloaded files saved to /sdcard/Download must be exempt. Also, the user might rename/move downloaded files anywhere else which means this privacy "protection" makes zero sense. Also, downloaded files might be recovered using direct access to the underlying media. If you're reluctant to leave downloaded files be, I'd suggest either changing the wording to "Downloads and Downloaded Files" or, if you're paranoid, introduce two options instead of one: "List of Downloads" and "Downloaded Files" which actually makes sense. Anyways I strictly prefer to go away with this madness because common sense says that downloaded files is not Firefox' prerogative and Firefox should not touch the files after they've been downloaded. Most, if not all users expect to be able to actually use their downloaded files after quitting the web browser. Firefox clearly goes against this sentiment. The current behaviour must either be reversed or the wording must be changed to reflect the actual behaviour.
Just lost all downloaded files. Wanted to clear a big download history, it was quite slow. Couldn't think the only delete option means file removal and not just clearing the list. See such an implementation for the first time, I think. Any chance to recover even the list (until sqlite does vacuum, or smth else)? Device is not rooted, Android 6.0.1

i find it upsetting that any firefox devs think it's fine to have this program deleting user files. outrageous. further, this is only considered an enhancement. it should be a critical type of bug.
i personally have had files i was depending on deleted many times. this is unacceptable.
if i click on a pdf, it says "downloaded" and the file appears in my downloads folder. this indicates to me that i now own the file. i do not expect any program to be deleting it.

at the very least, the 'clear data' check mark needs to specify that it will delete downloads.

still, the behavior is unacceptable because no program should be deleting files from a users downloads folder. that is user space. NEVER MESS WITH USER SPACE.

it creates a situation where the user cannot rely on their downloads folder, which is also being used by different programs. in practice, a user might look at their downloads folder to see if they have a certain file, without knowing if that file is subject to being deleted by firefox.

easy lazy quick fix: add text to the checkbox to WARN users of deletion of DOWNLOADS.

the eliminate-bad-code solution: don't delete downloads, and warn users that downloads (anything in the downloads folder) won't be deleted.
i think this is obviously the best because it mimicks desktop behavior. but now you have a few people (i ague that these are the minority) who are expecting files to be deleted...

the enhancement solution: add an option to delete/not-delete downloads.
if people just can't agree on either of the first two solutions.

somebody please heighten the priority of this bug. thanks.

I just can't understand how undeclared/hidden losing of files can be non-alternative default.

Same related bug: Allow clearing the downloads history from the download manager

People have given valid reasons for why Firefox for Android should not delete files from storage and nobody has given a valid reason why the current bug should remain as is. If the prompt said "Delete all previously downloaded files", then at least it would be doing what it says its doing. But instead it says one thing and does something else which results in permanent data loss.

Really seems like a no-brainer, but who knows...

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: