Closed
Bug 1392921
Opened 7 years ago
Closed 7 years ago
Fix the wrong clipping problem on chrome ui in layers-free mode
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: ethlin, Assigned: ethlin)
References
Details
Attachments
(1 file)
It looks like a regression of bug 1389138. I will try to have a patch for it.
|
Assignee | |
Comment 1•7 years ago
|
||
I can reproduce the problem when loading a larger page, e.g.: "https://tw.yahoo.com". The refresh icon isn't clipped correctly.
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8900141 [details]
Bug 1392921 - In TopmostScrollId(), return FrameMetrics::NULL_SCROLL_ID when the scroll id stack is empty.
https://reviewboard.mozilla.org/r/171534/#review176752
This is fine, although since the function now never returns Nothing() we can change the return type to just a plain FrameMetrics::ViewID instead of a Maybe<>. Feel free to make that change as well (the call sites will need to be tweaked accordingly). Or you can land this as-is, that's fine too.
Attachment #8900141 -
Flags: review?(bugmail) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
Okay, I will change the return type.
| Comment hidden (mozreview-request) |
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d41aab9f4c34
In TopmostScrollId(), return FrameMetrics::NULL_SCROLL_ID when the scroll id stack is empty. r=kats
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•