Closed
Bug 1392959
Opened 7 years ago
Closed 7 years ago
New about:accounts action needed, "email"
Categories
(Firefox :: Sync, enhancement, P3)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
Firefox 57
People
(Reporter: stomlinson, Assigned: gasolin)
References
()
Details
(Whiteboard: [fxa][photon-onboarding])
Attachments
(1 file)
The new onboarding tour for Photon has (or at least had, today's doesn't seem to have it) a "Sync" section [1] that allows users to enter their email address. When the user enters their email address and submits the form, about:accounts?action=signup is opened with the email address. It would be nice if we could instead send the user to about:accounts?action=email where action=email opens FxA's `/` route with the `?action=email&email=<email>` query parameters. From there, we'll determine whether the email is registered or not and direct the user down the correct flow.
[1] - https://bugzilla.mozilla.org/show_bug.cgi?id=1357023
Reporter | ||
Updated•7 years ago
|
Whiteboard: [fxa]
Comment 2•7 years ago
|
||
I've reached out to the onboarding team on Slack to bring this bug to their attention.
I'll leave the ni? on me until they answer.
Comment 3•7 years ago
|
||
Rex is this something we can do? Sounds straightforward.
Flags: needinfo?(rexboy)
Comment 4•7 years ago
|
||
The action to be taken is hard-coded in UITour.jsm, not in Onboarding module. It's possible to change it but would need some effort.
Given we are working on new proposal and some urgent bug fixing ongoing, I think we may prioritize it lower; but we can discuss it in triage.
Just a confirm, there are no works from fxa server side right?
Flags: needinfo?(rexboy)
Comment 5•7 years ago
|
||
Updated•7 years ago
|
Whiteboard: [fxa] → [fxa][photon-onboarding][triage]
Updated•7 years ago
|
Priority: -- → P3
Whiteboard: [fxa][photon-onboarding][triage] → [fxa][photon-onboarding]
Assignee | ||
Comment 6•7 years ago
|
||
Since we already send additional `email` option to UITour to visit about:accounts page with email address, we can alter the link in UITour to `about:accounts?action=email` when the method get `email` param.
With that change, we won't break others call and fulfill this request.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Assignee | ||
Updated•7 years ago
|
Flags: qe-verify+
Comment hidden (mozreview-request) |
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8905745 [details]
Bug 1392959 - send action=email when UITour called with email option;
https://reviewboard.mozilla.org/r/177546/#review182748
Looks fine to me but please modify the comment.
::: browser/components/uitour/UITour.jsm:562
(Diff revision 2)
> }
>
> case "showFirefoxAccounts": {
> - // 'signup' is the only action that makes sense currently, so we don't
> + let p;
> + if (data.email) {
> + // 'email' action help FxA determine whether the email is registered or not
Let's change the comment to avoid confusion within the else clause.
`With email parameter added, we need to use 'email' action to help FxA determine whether the email is registered or not.`
Attachment #8905745 -
Flags: review?(rexboy) → review+
Updated•7 years ago
|
Flags: needinfo?(adavis)
Comment hidden (mozreview-request) |
Comment 11•7 years ago
|
||
Pushed by flin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc6d97762cdb
send action=email when UITour called with email option;r=rexboy
Comment 12•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 13•7 years ago
|
||
I have verified that this issue is no longer reproducible on Win 10 x64, Win 7 x86, Mac 10.13, & Ubuntu 16.04 x32 with Firefox 58.
status-firefox58:
--- → verified
Comment 14•7 years ago
|
||
I can confirm the intended behavior is respected on beta. I verified using Fx 57.0b7 on Windows 10 x64, Ubuntu 14.04 LTS and macOS X 10.12.6.
You need to log in
before you can comment on or make changes to this bug.
Description
•