Closed
Bug 1393196
Opened 7 years ago
Closed 5 years ago
gfx/ has lots of signed/unsigned comparisons that generate warnings
Categories
(Core :: Graphics, defect, P3)
Core
Graphics
Tracking
()
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
firefox57 | --- | wontfix |
People
(Reporter: tjr, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor][gfx-noted])
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
Details |
In many places in gfx/ we compare unsigned and signed ints.
I'm compiling for Windows, on Linux (Bug 1330608) so it's exposing lots of warnings. I'm trying to understand how many of these we care about (if any) and if they are brand-new or if we had previously seen them and chosen to disable the warning or something.
One class I identified is we have a DXGI_SWAP_CHAIN_DESC object (https://msdn.microsoft.com/en-us/library/windows/desktop/bb173075(v=vs.85).aspx ) with a submember of type DXGI_MODE_DESC (https://msdn.microsoft.com/en-us/library/windows/desktop/bb173064(v=vs.85).aspx ). We often compare this object to a Mozilla type: LayoutDeviceIntSize which is signed. I've attached a patch that shows several of these sites (with a naive attempt at safely resolving them.)
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
We should probably be more deliberate about what we do here.
Flags: needinfo?(bas)
Updated•7 years ago
|
Whiteboard: [tor] → [tor][gfx-noted]
Updated•7 years ago
|
Priority: -- → P3
Updated•7 years ago
|
status-firefox57:
--- → wontfix
Reporter | ||
Comment 3•5 years ago
|
||
Compiling with gcc for Windows is not supported anymore, so this is a WONTFIX
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
Updated•3 years ago
|
Flags: needinfo?(bas)
You need to log in
before you can comment on or make changes to this bug.
Description
•