Closed
Bug 1393212
Opened 7 years ago
Closed 5 years ago
Chromium's IPC Code Generates a lot of warnings when compiled with gcc
Categories
(Core :: IPC, defect, P5)
Core
IPC
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: tjr, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor])
Attachments
(2 files)
Bug 1393212 Ignore unknown pragmas and unused variables and functions in ipc/chromium in MinGW build
(deleted),
text/x-review-board-request
|
Details | |
(deleted),
text/x-review-board-request
|
Details |
When compiling with gcc for Windows, there are a bunch of warnings that fall into (at least) four categorizes:
a) unknown pragmas that are caused by MSVC's pragma warning features (which I intend to disable project wide in this build config)
b) Unused variables
c) Unused functions
d) signed/unsigned comparisons
Several instances of (d) is caused by constant mismatching: TLS_OUT_OF_INDEXES is a DWORD according to microsoft, which is an unsigned int. We treat it as a long.
The attached patch resolves a through c. I'd like guidance on what to do for (d), maybe some combination of: try to fix them in mozilla codebase, file a bug upstream, ignore them.
Ignoring them will require disabling warnings-as-errors for this project in the mingw build. (Which I am okay with.)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Reporter | ||
Comment 3•7 years ago
|
||
Flagging a couple peers in IPC to get input on what they would like to see.
Flags: needinfo?(kchen)
Flags: needinfo?(jld)
Comment 4•7 years ago
|
||
We can suppress the warnings, but the error log might be interesting — patches to clean up ipc/chromium/src, especially if they're mostly or entirely deletions, are of interest. (For better or worse, it's a hard fork of upstream Chromium and won't be merged except maybe by throwing it all out and starting over, so we're free to alter it.)
Flags: needinfo?(jld)
Comment 5•7 years ago
|
||
What Jed said. Eventually I'd like to throw the chromium bits all out.
Flags: needinfo?(kchen)
Updated•7 years ago
|
Priority: -- → P5
Reporter | ||
Updated•7 years ago
|
Assignee: tom → nobody
Reporter | ||
Comment 6•5 years ago
|
||
Compiling with gcc for Windows is not supported anymore, so this is a WONTFIX
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•