Closed
Bug 1393222
Opened 7 years ago
Closed 7 years ago
gcc seems inept at detecting unused functions when compiling for Windows
Categories
(Core :: General, enhancement)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor])
Attachments
(1 file)
Many (but not all, because I had already disabled some) examples are in this log: https://public-artifacts.taskcluster.net/a3lYG5MRTUabRvllNBK8mw/0/public/logs/live_backing.log
See Bug 1392677 for an example of a false positive.
In some cases gcc is doing the best it can, but because we #ifdef out the callsite, the warning is a true positive we would not correct.
In general, I'd like to disable this warning for the MinGW Windows build.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2e19926efe4582549660f7fe1016cb98c1c705b
(Again, build will fail, but log should have no unused-function warnings)
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8900461 [details]
Bug 1393222 Disable the unused-function warning when compiling with gcc for Windows
https://reviewboard.mozilla.org/r/171824/#review177146
(Argh, sorry, I thought I submitted this review.) This is kind of a big hammer; do we really get that many warnings? Or is it just that they are errors? (I know MSVC complains about some of our third-party libraries, but obviously the warnings there are not errors.)
Attachment #8900461 -
Flags: review?(nfroyd) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2714bc3d1e9b
Disable the unused-function warning when compiling with gcc for Windows r=froydnj
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•