Closed
Bug 1393379
Opened 7 years ago
Closed 7 years ago
Make MediaDecoder::AddSizeOfResources pure virtual
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(2 files)
Sub-classes have more details about how to calculate the resource size. It also allows up to remove SizeOfExcludingThis() and SizeOfIncludingThis() from MediaResource.
|
Assignee | |
Updated•7 years ago
|
|
|
Assignee | |
Comment 1•7 years ago
|
||
This is also a step forward to remove MediaDecoder::GetResource() and make porting to Servo easier.
Blocks: servo-media
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8901672 -
Flags: review?(gsquelart)
Attachment #8901673 -
Flags: review?(gsquelart)
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8901672 [details]
Bug 1393379. P1 - make MediaDecoder::AddSizeOfResources pure virtual.
https://reviewboard.mozilla.org/r/173098/#review178446
Attachment #8901672 -
Flags: review?(gsquelart) → review+
|
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8901673 [details]
Bug 1393379. P2 - remove MediaResource::SizeOfIncludingThis/SizeOfExcludingThis.
https://reviewboard.mozilla.org/r/173100/#review178448
Attachment #8901673 -
Flags: review?(gsquelart) → review+
|
|
Assignee | |
Comment 6•7 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6683845d49b5
P1 - make MediaDecoder::AddSizeOfResources pure virtual. r=gerald
https://hg.mozilla.org/integration/autoland/rev/fdade67e7e78
P2 - remove MediaResource::SizeOfIncludingThis/SizeOfExcludingThis. r=gerald
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6683845d49b5
https://hg.mozilla.org/mozilla-central/rev/fdade67e7e78
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•