Closed
Bug 1393397
Opened 7 years ago
Closed 7 years ago
Hard to see Sidebars item in customize mode with Dark theme
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1384686
People
(Reporter: euthanasia_waltz, Unassigned)
Details
Attachments
(3 files)
when sidebar is hidden, white icon - desirable
Sidebars item icon is affected by sidebar visibility. If sidebar is shown, the item is drawn dark on dark.
|
||
Comment 3•7 years ago
|
||
Does this happen irrespective of the location of the button, or only when it's in the customization palette / "Drag your favorite items..."-labelled bit?
Flags: needinfo?(euthanasia_waltz)
Whiteboard: [photon-visual][triage]
|
||
Updated•7 years ago
|
Whiteboard: [photon-visual][triage] → [photon-structure][triage]
|
||
Comment 4•7 years ago
|
||
(In reply to :Gijs from comment #3)
> Does this happen irrespective of the location of the button, or only when
> it's in the customization palette / "Drag your favorite items..."-labelled
> bit?
Only in the palette. It comes from here:
http://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/toolkit/themes/windows/global/toolbarbutton.css#69
Probably need to override this more explicitly with color: inherit; or something.
|
|
||
Updated•7 years ago
|
Flags: qe-verify+
Priority: -- → P4
QA Contact: gwimberly
Whiteboard: [photon-structure][triage] → [reserve-photon-structure]
|
||
Updated•7 years ago
|
| Comment hidden (mozreview-request) |
|
|
||
Updated•7 years ago
|
Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Priority: P4 → P1
|
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8908744 [details]
Bug 1393397 - Use the correct color for checked items in customize palette.
https://reviewboard.mozilla.org/r/180374/#review185712
Thanks!
Attachment #8908744 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8908744 [details]
Bug 1393397 - Use the correct color for checked items in customize palette.
https://reviewboard.mozilla.org/r/180374/#review185714
::: browser/themes/shared/customizableui/customizeMode.inc.css:240
(Diff revision 1)
>
> #customization-palette .toolbarbutton-1 {
> fill: currentColor;
> }
>
> +#customization-palette .toolbarbutton-1[checked="true"]:not([disabled="true"]) {
I wonder if this also works if instead of `#customization-palette` with a descendant selector you use:
```css
toolbarpaletteitem[place="palette"] > .toolbarbutton-1[checked="true"]:not([disabled="true"])
```
|
||
Comment 9•7 years ago
|
||
Turns out this is a dupe of 1384686, where a more general fix for this just landed.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
|
|
||
Updated•7 years ago
|
Assignee: sfoster → nobody
Flags: qe-verify+
Priority: P1 → --
QA Contact: gwimberly
Whiteboard: [reserve-photon-structure]
|
|
||
Updated•7 years ago
|
status-firefox57:
affected → ---
QA Contact: Virtual
You need to log in
before you can comment on or make changes to this bug.
Description
•