Closed
Bug 1393515
Opened 7 years ago
Closed 7 years ago
Create a mixin to show exactly which properties should be added to shouldComponentUpdate()
Categories
(DevTools :: General, enhancement, P2)
DevTools
General
Tracking
(firefox57 fix-optional)
RESOLVED
WONTFIX
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fix-optional |
People
(Reporter: miker, Assigned: miker)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Screen Shot 2017-09-13 at 13.28.20.png
We should create a new mixin that can be used to identify exactly which properties should be added to shouldComponentUpdate() as this will greatly simplify the development process.
Output should be a complete shouldComponentUpdate function e.g.
```
shouldComponentUpdate(nextProps, nextState) {
return this.props.depth !== nextProps.depth ||
this.props.focused !== nextProps.focused;
},
```
Of course, to get all of the props we will need to do everything that can be done with the component but this would save a *lot* of time when optimizing the React components.
|
Assignee | |
Comment 1•7 years ago
|
||
We can't auto-generate shouldComponentUpdate() because of the many object types we have but we can show exactly which properties have changed for a particular component.
| Comment hidden (mozreview-request) |
|
||
Updated•7 years ago
|
status-firefox57:
--- → fix-optional
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8907696 [details]
Bug 1393515 - Create mixin to show which props should be added to shouldComponentUpdate()
https://reviewboard.mozilla.org/r/179360/#review186502
looks good. What is the process for turning this on? Do i need to know about the pref? Will this be needed if we upgrade react and can use react.pref?
|
|
Assignee | |
Comment 4•7 years ago
|
||
For the moment we have decided to stick with using perf.html and React 16's excellent markers. If we decide to use HOCs we can always reopen this bug.
Status: NEW → RESOLVED
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Closed: 7 years ago
OS: Unspecified → All
Hardware: Unspecified → All
Resolution: --- → WONTFIX
|
|
||
Updated•7 years ago
|
Attachment #8907696 -
Flags: review?(jlaster)
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•