Closed
Bug 1394442
Opened 7 years ago
Closed 7 years ago
Clear the Transcode buffer after decoding.
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: nbp, Assigned: nbp)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
At the moment, the bytecode buffer are kept alive after the evaluation as long as the script load request is alive. This is likely to be the issue reported in Bug 900784 comment 130.
We have multiple option, we can:
1. Clear the bytecode buffer where the source buffer is cleared, after the call to EvaluateScript.
2. Move the bytecode buffer into the decoder function, having for side-effect of clearing the original buffer.
3. Clear the bytecode buffer in the decoder.
Assignee | ||
Comment 1•7 years ago
|
||
This patch implement the option 1 of comment 0, i-e to clear the bytecode
buffer after the end of the EvaluateScript function call, where we are
already cleaning the source.
The check for IsBytecode is used to ensure that we were decoding, and never
encoding. Thus keeping the SRI bits in the buffer if we might want to
encode the script bytecode later.
Attachment #8901860 -
Flags: review?(mrbkap)
Updated•7 years ago
|
Attachment #8901860 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 2•7 years ago
|
||
Testing on Try, attachment 8901860 [details] [diff] [review] does not seems to fix the issue reported in Bug 900784 comment 130.
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/33a50b654311
Clear the bytecode buffer after the evaluation. r=mrbkap
Comment 4•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•