Dave Townsend [:mossop] Reporter
	Description • 7 years ago

The down arrow in the url bar that you click to open the popup shows and hides in some strange cases making it appear and disappear while you mouse around the window.

It is shown when the mouse is over:

The URL bar
Other toolbar buttons
The bottom border of the toolbars

It is not shown when the mouse is over:

Tab bar
Flexible spacers
The content area

	Dão Gottwald [:dao]
	Comment 1 • 7 years ago

(In reply to Dave Townsend [:mossop] from comment #0)
> It is not shown when the mouse is over:
> 
> Tab bar
> Flexible spacers

We're not seeing this bug on Linux or Mac. Can you reproduce in a new profile?

> The content area

This is expected behavior (bug 1203494).

	Dave Townsend [:mossop] Reporter
	Comment 2 • 7 years ago

I tested in a clean profile on Windows.

(In reply to Dave Townsend [:mossop] from comment #0)
> The down arrow in the url bar that you click to open the popup shows and
> hides in some strange cases making it appear and disappear while you mouse
> around the window.
> 
> It is shown when the mouse is over:
> 
> The URL bar
> Other toolbar buttons
> The bottom border of the toolbars
> 
> It is not shown when the mouse is over:
> 
> Tab bar

This is slightly false, over tabs the drop-down shows, over the rest of the titlebar it doesn't.

> Flexible spacers

This only occurs when a lightweight theme is applied.

	Dave Townsend [:mossop] Reporter
	Comment 3 • 7 years ago

The dropmarker also disappears while the hamburger menu is animating open.

	:Gijs (he/him)
	Comment 5 • 7 years ago

The problem here is that we're basically setting the dropdown to appear when the toolbox is hovered, so:

- menus that drop down from those buttons don't count
- items that get no mouse events because they get treated as native titlebar bits (like the empty space in the tabstrip) don't count

Fixing this is not trivial, because this is currently set up using CSS with a :hover style on the toolbox.

TBH, I think we should just get rid of the dropmarker, that's what people have been saying for months, and there's a separate bug on file for doing that. Stephen?

	Florian Quèze [:florian] Assignee
	Comment 8 • 7 years ago

From the duplicate bug 1401507 - URL bar dropmarker appears when hovering tabs or toolbar buttons

> The urlbar dropmarker appears whenever I hover the searchbar, a random
> toolbar button, or a tab. This is distracting (especially with the css
> transition) as it causes something to move in a place that is unrelated to
> where my mouse cursor is.
> 
> I did some bugzilla and hg archeology and was surprised to see this behavior
> was intentionally introduced in bug 1211217.
> 
> Jared, I assume you wanted this to appear when the mouse is around the
> urlbar, not when it's over anything in the top of the browser window.
> 
> Before your patch we were checking for :not(:hover) on #urlbar which was
> indeed a small target. Currently (after your patch) we do it on
> #navigator-toolbox which is a giant target. I think #urlbar-container is a
> good compromise. Do you agree?

Stephen, the options that have been proposed here are:

1. just get rid of the dropmarker (what Gijs is proposing here in comment 5). It may already be late to introduce this change in 57.

2. show the dropmarker only when hovering the urlbar (ie. revert to the situation before bug 1211217)

3. show the dropmarker when hovering the urlbar container (ie. the urlbar + a few pixels immediately around it). This is what the patch I'm attaching does.

4. Keep the current distracting and inconsistent behavior.

What would you like us to do?

	Jared Wein [:jaws] (please needinfo? me)
	Comment 10 • 7 years ago

Comment on attachment 8910275 [details] [diff] [review]
Patch from bug 1401507

Review of attachment 8910275 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, the goal of this is to show the dropmarker as the user begins to mouse towards it. I'm fine with this change.

	Stephen Horlander [:shorlander]
	Comment 11 • 7 years ago

(In reply to Florian Quèze [:florian] [:flo] from comment #8)
> 1. just get rid of the dropmarker (what Gijs is proposing here in comment
> 5). It may already be late to introduce this change in 57.

I think we should consider removing it (we've discussed it for years) I filed bug 1389594 to get some data on usage for after 57.

> 3. show the dropmarker when hovering the urlbar container (ie. the urlbar +
> a few pixels immediately around it). This is what the patch I'm attaching
> does.

This sounds fine to me in the short-term. Thanks!

	Pulsebot
	Comment 12 • 7 years ago

Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d375b8dad67e
URL bar drop-down arrow should only be shown when hovering the urlbar container, r=jaws, ui-r=shorlander.

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 13 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/d375b8dad67e

	Saritha
	Comment 14 • 7 years ago

I have reproduced the issue on an affected build 57.0a1 (20170828100127)on Windows10 64bit

This is verified fixed on Windows 10 and Windows 7 64bit - Build 57.0b3(20170925150345)

The URL bar drop-down arrow is shown only when hovering the urlbar container.

	roxleitan
	Comment 15 • 7 years ago

Based on comment 14 I will mark firefox57 flag	-- verified