Closed
Bug 1394648
Opened 7 years ago
Closed 7 years ago
Switch from nsInt{Point,Rect,Size} to gfx::Int{Point,Rect,Size} in dom/media/
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: cpearce, Assigned: cpearce)
References
Details
Attachments
(3 files)
Include graph before change
We're using nsIntRect, nsIntPoint, and nsIntSize in MediaInfo.h and other media classes. These are actually typedef'd to gfx::IntRect, gfx::IntPoint, and gfx::IntSize in nsRect.h and nsSize.h, which we're including. However a bunch of otherstuff we don't need is also included in those headers, so if we switched to using the gfx classes directly, we'd have a simpler include graph.
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 4•7 years ago
|
||
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8902094 [details]
Bug 1394648 - Switch from nsInt{Point,Rect,Size} to gfx::Int{Point,Rect,Size} in dom/media.
https://reviewboard.mozilla.org/r/173528/#review178882
Attachment #8902094 -
Flags: review?(jwwang) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19c91c598eed
Switch from nsInt{Point,Rect,Size} to gfx::Int{Point,Rect,Size} in dom/media. r=jwwang
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•