Closed
Bug 1394656
Opened 7 years ago
Closed 7 years ago
Reduce includes in AudioSampleFormat.h and SharedBuffer.h
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: cpearce, Assigned: cpearce)
References
Details
Attachments
(2 files)
AudioSampleFormat.h includes nsCOMPtr.h, which it does use. This causes cycle collection stuff to be pulled into the build.
It also includes nsAlgorithm.h, which is unsed and pulls in other stuff we don't use.
|
Assignee | |
Comment 1•7 years ago
|
||
(In reply to Chris Pearce (:cpearce) from comment #0)
> AudioSampleFormat.h includes nsCOMPtr.h, which it does use. This causes
> cycle collection stuff to be pulled into the build.
Blah! SharedBuffer.h includes nsCOMPtr, which is unused.
Summary: Reduce includes in AudioSampleFormat.h → Reduce includes in AudioSampleFormat.h and SharedBuffer.h
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8902089 [details]
Bug 1394656 - Don't include nsAlgorithm.h in AudioSampleFormat.h.
https://reviewboard.mozilla.org/r/173520/#review178878
Attachment #8902089 -
Flags: review?(jwwang) → review+
|
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8902090 [details]
Bug 1394656 - Don't include nsCOMPtr.h in SharedBuffer.h as its unused.
https://reviewboard.mozilla.org/r/173522/#review178880
Attachment #8902090 -
Flags: review?(jwwang) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26226638b6a6
Don't include nsAlgorithm.h in AudioSampleFormat.h. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/859bd485c707
Don't include nsCOMPtr.h in SharedBuffer.h as its unused. r=jwwang
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/26226638b6a6
https://hg.mozilla.org/mozilla-central/rev/859bd485c707
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•