Closed
Bug 1395021
Opened 7 years ago
Closed 7 years ago
Move TrackID definition out of StreamTracks.h
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: cpearce, Assigned: cpearce)
References
Details
Attachments
(2 files)
Having TrackID in StreamTracks.h means that MediaInfo.h, which includes StreamTracks.h, ends up pulling in the MSG and a bunch of DOM bindings code. If we move it out to its own file, we'll get a simpler include graph, at least for the playback code.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8902515 [details]
Bug 1395021 - Move TrackID definition from StreamTracks.h into TrackID.h.
https://reviewboard.mozilla.org/r/174100/#review179370
Attachment #8902515 -
Flags: review?(jwwang) → review+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8902516 [details]
Bug 1395021 - Fix up includes to account for StreamTracks.h not being indirectly included in so many places.
https://reviewboard.mozilla.org/r/174102/#review179372
Attachment #8902516 -
Flags: review?(jwwang) → review+
Comment 5•7 years ago
|
||
It would be easier to detect over/insufficient includes if we build all files under dom/media in non-unified mode.
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/620ce0f4d360
Move TrackID definition from StreamTracks.h into TrackID.h. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/1ed072a5827f
Fix up includes to account for StreamTracks.h not being indirectly included in so many places. r=jwwang
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/620ce0f4d360
https://hg.mozilla.org/mozilla-central/rev/1ed072a5827f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•