> WARNING - TEST-UNEXPECTED-FAIL | /home/worker/workspace/build/src/testing/xpcshell/selftest.py | XPCShellTestsTests.testAddTaskRunNextTest, line 1049: No module named fix_linux_stack I traced this to http://searchfox.org/mozilla-central/source/testing/mozbase/mozrunner/mozrunner/utils.py#284 where it thinks we are Linux, because well we sure look like Linux I bet! The problem is, I'm not quite sure where in mozinfo we set isLinux, and even if I corrected it, I'm not sure we could run tests successfully in the current way we run tests!

(In reply to Tom Ritter [:tjr] from comment #0) > The problem is, I'm not quite sure where in mozinfo we set isLinux, and even > if I corrected it, I'm not sure we could run tests successfully in the > current way we run tests! We set it here: http://searchfox.org/mozilla-central/source/testing/mozbase/mozinfo/mozinfo/mozinfo.py#255 or thereabouts. At least that selftest check probably needs to be updated to consider the *target* machine we're running on, rather than the host...and there are probably many other instances besides, since 'isLinux' probably worked OK for the other major cross-compilation case of Android on Linux.

(In reply to Nathan Froyd [:froydnj] from comment #1) > (In reply to Tom Ritter [:tjr] from comment #0) > > The problem is, I'm not quite sure where in mozinfo we set isLinux, and even > > if I corrected it, I'm not sure we could run tests successfully in the > > current way we run tests! > > We set it here: > > http://searchfox.org/mozilla-central/source/testing/mozbase/mozinfo/mozinfo/ > mozinfo.py#255 > > or thereabouts. At least that selftest check probably needs to be updated > to consider the *target* machine we're running on, rather than the > host...and there are probably many other instances besides, since 'isLinux' > probably worked OK for the other major cross-compilation case of Android on > Linux. n.b.: we don't (and have never) run `make check` on any of our cross-compiled builds, for this and other reasons.

We went through this same rigamarole with the cross-mac builds in bug 1340698.

Comment on attachment 8916374 [details] Bug 1395047 Don't run 'make check' on a cross compiled build https://reviewboard.mozilla.org/r/187538/#review192812 ::: browser/config/mozconfigs/win32/mingw32:50 (Diff revision 1) > > # GCC compiling for Windows exposes a lot of warnings. We are tracking them in Bug 1394433 > ac_add_options --disable-warnings-as-errors > > # Temporary config settings until we get these working on mingw > -ac_add_options --disable-tests > +ac_add_options --enable-tests You should be able to drop this, --enable-tests is the default.

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #5) > You should be able to drop this, --enable-tests is the default. Thanks, fixed. Will land this once I get Bug 1406736 sorted (which is breaking the -tests build).

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7ce72fc1ce81 Don't run 'make check' on a cross compiled build r=ted