Closed
Bug 1395091
Opened 7 years ago
Closed 7 years ago
about:telemetry global search should have headings before section results
Categories
(Toolkit :: Telemetry, enhancement, P3)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: gfritzsche, Assigned: o0ignition0o, Mentored)
References
Details
Attachments
(2 files)
Currently the global search in the about:telemetry homepage does not make clear what section results come from.
We should show labels/headings to make this clear.
Comment 1•7 years ago
|
||
This is an item mentioned in bug 1393478. It isn't in the current batch of patches, so maybe this bug's a good chance to break this out a bit? What do you think, flyingrub?
Flags: needinfo?(flyinggrub)
Reporter | ||
Comment 3•7 years ago
|
||
Jeremy, would you be interested in taking this?
Flags: needinfo?(jeremy.lempereur)
Reporter | ||
Updated•7 years ago
|
Mentor: chutten
Reporter | ||
Comment 5•7 years ago
|
||
Cheers!
Here is an example of what i mean.
I searched for one term and get results from different categories/sections.
Because there are no separate headings, i can't tell which sections the results are actually from.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•7 years ago
|
||
http://ibb.co/iSyLKw I've put each section into an h1 tag, since I'm not a really great UI designer ^^'
I hope I've covered every corner case, if I haven't please let me know and I'll follow up on this :)
Reporter | ||
Comment 8•7 years ago
|
||
This looks more clear, cheers!
I'll redirect the review to Chris here.
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → jeremy.lempereur
Reporter | ||
Updated•7 years ago
|
Attachment #8939689 -
Flags: review?(gfritzsche) → review?(chutten)
Assignee | ||
Comment 9•7 years ago
|
||
Great thanks a lot ! If there's an other task you would like me to handle, please tell me. I'm trying to ramp up my js / c++ skills :)
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8939689 [details]
Bug 1395091 - about:telemetry global search should have headings before section results.
https://reviewboard.mozilla.org/r/209990/#review215940
Nice use of modern language features and APIs.
Attachment #8939689 -
Flags: review?(chutten) → review+
Comment 11•7 years ago
|
||
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/862df5b1a0c9
about:telemetry global search should have headings before section results. r=chutten
Comment 12•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•