Closed
Bug 1395296
Opened 7 years ago
Closed 6 years ago
Add /media/mtransport/ to the list of ignore
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox57 affected)
RESOLVED
WONTFIX
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | affected |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
ekr
:
review+
|
Details | Diff | Splinter Review |
ekr just told me that it is used the Google coding style
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8902867 -
Flags: review?(ekr)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8902867 [details] [diff] [review]
mtransport.diff
Review of attachment 8902867 [details] [diff] [review]:
-----------------------------------------------------------------
I think you can also remove media/mtransport/test (because it is duplicated)
::: tools/rewriting/ThirdPartyPaths.txt
@@ +39,5 @@
> media/libtremor/
> media/libvorbis/
> media/libvpx/
> media/libyuv/
> +media/mtransport/
This doesn't seem right. We wrote media/mtransport/[other than third party], we just used Google style
|
|
Assignee | |
Comment 3•7 years ago
|
||
> we just used Google style
Is it because we share this code with Google or just because the developers preferred Google's style over Mozilla's?
|
|
Assignee | |
Comment 4•7 years ago
|
||
Attachment #8902867 -
Attachment is obsolete: true
Attachment #8902867 -
Flags: review?(ekr)
Attachment #8902875 -
Flags: review?(ekr)
|
|
||
Comment 5•7 years ago
|
||
(In reply to Sylvestre Ledru [:sylvestre] from comment #3)
> > we just used Google style
> Is it because we share this code with Google or just because the developers
> preferred Google's style over Mozilla's?
The latter
|
|
||
Comment 6•7 years ago
|
||
Comment on attachment 8902875 [details] [diff] [review]
mtransport.diff
Review of attachment 8902875 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8902875 -
Flags: review?(ekr) → review+
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
|
Assignee | |
Comment 8•7 years ago
|
||
Not yet, we are still having discussions about coding style.
Flags: needinfo?(sledru)
|
|
Assignee | |
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•