Closed
Bug 1395355
Opened 7 years ago
Closed 7 years ago
Distribtion Locale search specific plugins broke in Firefox 56
Categories
(Firefox for Android Graveyard :: Android partner distribution, defect)
Firefox for Android Graveyard
Android partner distribution
Tracking
(firefox-esr52 unaffected, firefox55 wontfix, firefox56 fixed, firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | wontfix |
firefox56 | --- | fixed |
firefox57 | --- | fixed |
People
(Reporter: mkaply, Assigned: mkaply)
References
Details
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
zbraniecki
:
review+
lizzard
:
approval-mozilla-beta+
jcristau
:
approval-mozilla-release-
|
Details |
It looks like the recent locale changes broke distribution plugins:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/components/DirectoryProvider.js#116
TypeError: Services.locales is undefined
Comment 2•7 years ago
|
||
Ugh, thanks for noticing! The spelling is my fault - it should be 'Services.locale', not 'Services.locales'.
And thank you for volunteering to fix it after me!
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8902928 -
Flags: review?(gandalf) → review+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8902928 [details]
Bug 1395355 - Typo preventing locale distribution engines from loading.
https://reviewboard.mozilla.org/r/174662/#review179746
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8902928 [details]
Bug 1395355 - Typo preventing locale distribution engines from loading.
Approval Request Comment
[Feature/Bug causing the regression]: bug 1346616
[User impact if declined]: No direct user impact. Distribution locales don't work
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No, but simple typo
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Non
[Is the change risky?]: No
[Why is the change risky/not risky?]: Fix typo. Distribution only.
[String changes made/needed]: None
I'm marking for release just in case we do another . release. Would be nice to have, but not needed.
Attachment #8902928 -
Flags: approval-mozilla-release?
Attachment #8902928 -
Flags: approval-mozilla-beta?
Comment on attachment 8902928 [details]
Bug 1395355 - Typo preventing locale distribution engines from loading.
Typo fix, let's uplift this for beta 8.
Attachment #8902928 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•7 years ago
|
||
bugherder uplift |
status-firefox56:
--- → fixed
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/2588e09380d0
Typo preventing locale distribution engines from loading. r=gandalf
Updated•7 years ago
|
status-firefox55:
--- → fix-optional
status-firefox57:
--- → affected
status-firefox-esr52:
--- → unaffected
Comment 9•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 10•7 years ago
|
||
Comment on attachment 8902928 [details]
Bug 1395355 - Typo preventing locale distribution engines from loading.
no more dot releases planned for 55, m-r is about to become 56.
Attachment #8902928 -
Flags: approval-mozilla-release? → approval-mozilla-release-
Updated•7 years ago
|
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•