Closed
Bug 1395557
Opened 7 years ago
Closed 7 years ago
Customtab: security level of site not displayed same as Fennec
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: sflorean, Assigned: snorp)
References
Details
Attachments
(2 files)
Environment:
Device: Huawei Honor (Android 5.1.1);
Build: Nightly 57.0a1 (2017-08-30);
Prerequisite: Custom tabs are enabled in settings.
Steps to reproduce:
1. Go to https://planet.mozilla.org/ or https://adalet.gov.tr/ launching CustomTab activity.
2. Observe and tap on Grey globe from custom toolbar.
Expected result:
- Insecure connection (Parts of page are insecure - Yellow sign) is displayed.
Actual result:
Grey globe displayed instead of yellow sign (like in Fennec).
"Learn more" link not displayed.
Assignee | ||
Updated•7 years ago
|
Updated•7 years ago
|
Priority: -- → P1
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: droeh → snorp
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8907716 [details]
Bug 1395557 - Show the right icon for mixed passive mode in Custom Tabs
https://reviewboard.mozilla.org/r/179386/#review184550
::: mobile/android/base/java/org/mozilla/gecko/customtabs/ActionBarPresenter.java:217
(Diff revision 1)
> icon = SecurityModeUtil.IconType.UNKNOWN;
> } else {
> icon = SecurityModeUtil.IconType.LOCK_SECURE;
> }
> +
> + if ("loaded".equals(security.mixedModePassive)) {
Should be merged as an "else if" into the previous conditional block.
Do we also need to check for mixedModeActive here?
Attachment #8907716 -
Flags: review?(esawin) → review+
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/199aa1b7d248
Show the right icon for mixed passive mode in Custom Tabs r=esawin
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 6•7 years ago
|
||
(In reply to Eugen Sawin [:esawin] from comment #3)
> Should be merged as an "else if" into the previous conditional block.
Ignore that, mixedModePassive loaded is supposed to override securityMode unknown.
Updated•7 years ago
|
Flags: needinfo?(droeh)
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•