Closed Bug 1395593 Opened 7 years ago Closed 7 years ago

Don't query the maximum channel count in ::PlayAudio using cubeb

Categories

(Core :: Audio/Video: MediaStreamGraph, defect, P1)

All
Unspecified
defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- fixed

People

(Reporter: padenot, Assigned: padenot)

References

Details

(Keywords: regression)

Attachments

(1 file)

Depending on the platform, this can be ridiculously expensive. For example, on Windows, it's basically create a new audio stream _each audio callback_. On OSX, it's doing a few system calls that are rather expensive, but not as expensive as windows (on OSX, this unnecessary cubeb call accounts for around 20% of the total callback time).
Regressed by bug 1378070, patch coming up.
Assignee: nobody → padenot
Severity: normal → critical
Rank: 10
Keywords: regression
Priority: -- → P1
Comment on attachment 8903180 [details] Bug 1395593 - Don't query the maximum channel count in ::PlayAudio using cubeb. https://reviewboard.mozilla.org/r/174964/#review180014 Looks good. It would be even better to have an assert on MediaStreamGraphImpl::AudioChannelCount() that it is not executed in a Real Time thread.
Attachment #8903180 - Flags: review?(achronop) → review+
Pushed by paul@paul.cx: https://hg.mozilla.org/integration/autoland/rev/eab0db5216b7 Don't query the maximum channel count in ::PlayAudio using cubeb. r=achronop
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/mozilla-central/rev/34933f6390d5 Don't query the maximum channel count in ::PlayAudio using cubeb. r=achronop a=ill-communication
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: