Closed
Bug 1395593
Opened 7 years ago
Closed 7 years ago
Don't query the maximum channel count in ::PlayAudio using cubeb
Categories
(Core :: Audio/Video: MediaStreamGraph, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | fixed |
People
(Reporter: padenot, Assigned: padenot)
References
Details
(Keywords: regression)
Attachments
(1 file)
Depending on the platform, this can be ridiculously expensive. For example, on Windows, it's basically create a new audio stream _each audio callback_.
On OSX, it's doing a few system calls that are rather expensive, but not as expensive as windows (on OSX, this unnecessary cubeb call accounts for around 20% of the total callback time).
Assignee | ||
Comment 1•7 years ago
|
||
Regressed by bug 1378070, patch coming up.
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8903180 [details]
Bug 1395593 - Don't query the maximum channel count in ::PlayAudio using cubeb.
https://reviewboard.mozilla.org/r/174964/#review180014
Looks good. It would be even better to have an assert on MediaStreamGraphImpl::AudioChannelCount() that it is not executed in a Real Time thread.
Attachment #8903180 -
Flags: review?(achronop) → review+
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/autoland/rev/eab0db5216b7
Don't query the maximum channel count in ::PlayAudio using cubeb. r=achronop
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/34933f6390d5
Don't query the maximum channel count in ::PlayAudio using cubeb. r=achronop a=ill-communication
Comment 7•7 years ago
|
||
There was a backout in between: https://hg.mozilla.org/mozilla-central/rev/cc85091ab81c7eb865d2cfb31539702c1bb7a18d The last comment was just the relanding.
Updated•7 years ago
|
Blocks: 1378070
status-firefox55:
--- → unaffected
status-firefox56:
--- → unaffected
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•