Build ID : 20170831100258 user Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 OS : Windows 7 , 64 Bit Steps to Reproduce : 1. Open Firefox Nightly 2. Open Customization and enable bookmark toolbar 3. Make sure you have another tab opened besides customization Actual Result : If I switch from customization tab to the other tab, the toolbar goes up (maybe by some pixel). And if I switch from that tab to customization ,the toolbar comes down. Expected Result: The toolbar should not show this kind of behavior

Comment on attachment 8904509 [details] Bug 1395596 - Avoid changing the bookmarks toolbar's height when entering customize mode and the toolar is non-empty. https://reviewboard.mozilla.org/r/176362/#review181250 ::: browser/themes/shared/browser.inc.css (Diff revision 1) > - /* There's no border in customize mode, so we don't need extra padding. */ > - padding-bottom: 0; Sorry, but why are we no longer removing the 1px padding set above this? Does the additional height match better that way, or something? :-)

(In reply to :Gijs (queue backed up, slow) from comment #2) > Comment on attachment 8904509 [details] > Bug 1395596 - Avoid changing the bookmarks toolbar's height when entering > customize mode and the toolar is non-empty. > > https://reviewboard.mozilla.org/r/176362/#review181250 > > ::: browser/themes/shared/browser.inc.css > (Diff revision 1) > > - /* There's no border in customize mode, so we don't need extra padding. */ > > - padding-bottom: 0; > > Sorry, but why are we no longer removing the 1px padding set above this? > Does the additional height match better that way, or something? :-) It would matter if we add support for custom / web extension toolbars (bug 1215064). Removing the padding doesn't seem useful anyway, or is there some specific problem this solves?

(In reply to Dão Gottwald [::dao] from comment #3) > (In reply to :Gijs (queue backed up, slow) from comment #2) > > Comment on attachment 8904509 [details] > > Bug 1395596 - Avoid changing the bookmarks toolbar's height when entering > > customize mode and the toolar is non-empty. > > > > https://reviewboard.mozilla.org/r/176362/#review181250 > > > > ::: browser/themes/shared/browser.inc.css > > (Diff revision 1) > > > - /* There's no border in customize mode, so we don't need extra padding. */ > > > - padding-bottom: 0; > > > > Sorry, but why are we no longer removing the 1px padding set above this? > > Does the additional height match better that way, or something? :-) > > It would matter if we add support for custom / web extension toolbars (bug > 1215064). Removing the padding doesn't seem useful anyway, or is there some > specific problem this solves? I think I originally intended to match the height of the toolbar with items vs. without items. But then I reduced the height after the review feedback, and there's bug 1389966 on file for that (sort of), so I don't really mind either way.

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c32a5bb6a6df Avoid changing the bookmarks toolbar's height when entering customize mode and the toolar is non-empty. r=Gijs

I have reproduced this bug with Nightly 57.0a1 (2017-08-31) on Ubuntu 16.04 LTS! This bug's fix is verified with latest Nightly! Build ID : 20170910100150 User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

I have reproduced this bug with Nightly 57.0a1 (2017-08-31) on Windows 8.1, 64-Bit ! This bug's fix is Verified with latest Nightly ! Build ID 20170909100226 User Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0 [bugday-20170906]

As per comment 7 and comment 8 , I am marking this bug as Verified Fixed!